convert shoppingList as static field and improve the get method to av…

…oid lazily initialization
quarkus-qe · Nov 15, 2023 · eb0c75b · eb0c75b
1 parent ddf9024
commit eb0c75b
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/http/vertx-web-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ShopResource.java b/http/vertx-web-validation/src/main/java/io/quarkus/ts/vertx/web/validation/ShopResource.java
@@ -14,9 +14,9 @@
 @Produces(MediaType.APPLICATION_JSON)
 public class ShopResource {
 
-    private List<ShoppingList> shoppingList;
+    private static List<ShoppingList> shoppingList = createSampleProductList();
 
-    private List<ShoppingList> createSampleProductList() {
+    private static List<ShoppingList> createSampleProductList() {
         shoppingList = new ArrayList<>();
         shoppingList.add(new ShoppingList(UUID.randomUUID(), "ListName1", 25,
                 new ArrayList<>(Arrays.asList("Carrots", "Water", "Cheese", "Beer"))));
@@ -27,9 +27,6 @@ private List<ShoppingList> createSampleProductList() {
 
     @GET
     public List<ShoppingList> get() {
-        if (shoppingList == null) {
-            createSampleProductList();
-        }
         return shoppingList;
     }