Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Video Mode #233
base: main
Are you sure you want to change the base?
Feat/Video Mode #233
Changes from 66 commits
3888e18
0479d50
e261bce
9a1eeb6
0a97b43
5eae7b2
25769c7
7f81002
9666d4f
ba715cc
736801e
e3bb6da
cc8044a
5221511
f78a29e
7a9bfa3
b87d69c
d173a9b
d1e1e7b
4eed737
408930a
6fdbd71
0319e12
f57b019
826ceb4
5ca0dd2
2afc1a0
b61b7d6
f4667ec
0a742b5
a727c1f
67d9c44
7c52262
0961e19
c20bee8
9436279
cc23127
1f89fb6
1fbdd4d
03200e5
aac74d4
f9fc9c7
afe02f1
6bd239a
37983de
f427ff5
abe284b
af95bbe
120a259
8bf8bec
f915a21
e2f1437
9af3017
af2df90
b94d5e1
e225da8
c31dcdc
c402658
e44b4dc
136efdc
9491850
a6e5194
a528d55
02b458c
5c2fb71
5af205e
e14c35a
57ad90e
927489a
3494768
b8eddd5
6bcc31f
1b04522
d8a62f9
7957070
320b713
53c4679
a49b36d
9664ce5
d715792
f1011bd
1765016
28d80bd
d56523a
75ad3df
cb6f908
002d916
a763eb5
6da9d9f
0283168
f15b37a
6ef93b2
b457e4e
2ab07e4
b8e25c8
88e6fd1
b22342c
46dc1b6
cc1978d
8e0581f
8ce9541
dea03bc
b782f90
540d852
6bebe88
100d4d7
9380b08
8e5fd37
dc0feb1
70c6cb3
303e46b
492a85d
00cf815
efb9b60
1cc556f
63af1bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from another PR right?
Is it also ready for review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, it works but lacks documentation and tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't understand how this works.
When VideoMode is running the kernel is being used so that you can't run anything there...
One solution could be to use what we did here: https://github.com/qua-platform/py-qua-tools/tree/main/qualang_tools/video_mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work, it needs external instrument calls. The way it works is as follows:
Two threads are created:
Video Mode dash app that runs an OPX program and repeatedly shows results
Voltage Control GUI that allows setting QDAC voltages