Explicitly turning off pybindings for ExecuTorch install unless requested #1475
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExecuTorch now has XNN pybinding built by default pytorch/executorch#7473 Previously it was not built by default
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1475
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 3 PendingAs of commit de19ea8 with merge base 0ee4aea ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Jack-Khuu
changed the title
Jack-Khuu
added
the
ExecuTorch
This was referenced Jan 24, 2025
Gasoonjia
approved these changes
Jan 24, 2025
|
👍 |
|
Thanks @Jack-Khuu, didn't realize this. Also, while we're at it. We have two commands now: install_requirements (only installs required dependency) and install_executorch (which does install_requirements underneath the hood as well as installs executorch). See attached PRs to this issue (pytorch/executorch#7730) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecuTorch now has XNN pybinding built by default pytorch/executorch#7473
Previously it was not built by default