-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android NDK version to r27c #1473
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1473
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 65432d6 with merge base 3ce9c8e (): CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
We should confirm that the Android demo still works with this change. https://github.com/pytorch/torchchat/tree/main/torchchat/edge/android |
Can we spin up an automated test of this? |
Yup, we should add a test for the demos; might be able to pull it from the ET repo The current test we're trying to fix just builds the android runner |
@Jack-Khuu maybe this? pytorch/executorch#5387 (comment) solves the -lextension_tensor ? |
This is for the Python build so it's not directly related That said I think I found the culprit: pytorch/executorch#7473
Fix: #1475 |
If that doesn't do it, maybe you want to add environment variables here. Because clearly that's how we turn on these extensions for other extensions, and the traceback of the build shows the EXTENSION TENSOR library as "OFF" atm. https://github.com/pytorch/torchchat/blob/main/runner/build_android.sh#L24-L25
|
Yup, yup that was the log that tipped me off that something changed in the ET installs |
No description provided.