Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android NDK version to r27c #1473

Closed
wants to merge 2 commits into from
Closed

Conversation

Jack-Khuu
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Jan 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1473

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 65432d6 with merge base 3ce9c8e (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@vmpuri
Copy link
Contributor

vmpuri commented Jan 23, 2025

We should confirm that the Android demo still works with this change. https://github.com/pytorch/torchchat/tree/main/torchchat/edge/android

@mikekgfb
Copy link
Contributor

We should confirm that the Android demo still works with this change. https://github.com/pytorch/torchchat/tree/main/torchchat/edge/android

Can we spin up an automated test of this?

@Jack-Khuu Jack-Khuu marked this pull request as draft January 23, 2025 22:31
@Jack-Khuu
Copy link
Contributor Author

Yup, we should add a test for the demos; might be able to pull it from the ET repo

The current test we're trying to fix just builds the android runner

@mikekgfb
Copy link
Contributor

@Jack-Khuu maybe this? pytorch/executorch#5387 (comment) solves the -lextension_tensor ?

@Jack-Khuu
Copy link
Contributor Author

Jack-Khuu commented Jan 24, 2025

This is for the Python build so it's not directly related

That said I think I found the culprit: pytorch/executorch#7473

  • XNNPack pybindings are now on by default

Fix: #1475

@mikekgfb
Copy link
Contributor

mikekgfb commented Jan 24, 2025

This is for the Python build so it's not directly related

That said I think I found the culprit: pytorch/executorch#7473

  • XNNPack pybindings are now on by default

If that doesn't do it, maybe you want to add environment variables here. Because clearly that's how we turn on these extensions for other extensions, and the traceback of the build shows the EXTENSION TENSOR library as "OFF" atm.

https://github.com/pytorch/torchchat/blob/main/runner/build_android.sh#L24-L25

export EXECUTORCH_BUILD_KERNELS_CUSTOM_AOT="OFF"
export EXECUTORCH_BUILD_KERNELS_CUSTOM="ON"

@Jack-Khuu
Copy link
Contributor Author

Jack-Khuu commented Jan 24, 2025

Yup, yup that was the log that tipped me off that something changed in the ET installs

#1475

@Jack-Khuu Jack-Khuu closed this Jan 24, 2025
@Jack-Khuu Jack-Khuu deleted the Jack-Khuu-patch-36 branch January 24, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants