Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation] Deprecate in prep for release #1820

Merged
merged 23 commits into from
Jan 31, 2024
Merged

[Deprecation] Deprecate in prep for release #1820

merged 23 commits into from
Jan 31, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jan 19, 2024 •
edited
Loading

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1820

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit bf4a0d9 with merge base 69453a6 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 89. Improved: $\large\color{#35bf28}1$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 63.8285ms 63.2387ms 15.8131 Ops/s 15.7800 Ops/s $\color{#35bf28}+0.21\%$
test_sync 46.5543ms 35.0897ms 28.4984 Ops/s 28.9583 Ops/s $\color{#d91a1a}-1.59\%$
test_async 0.1431s 33.3480ms 29.9868 Ops/s 29.5631 Ops/s $\color{#35bf28}+1.43\%$
test_simple 0.4971s 0.4398s 2.2739 Ops/s 2.2674 Ops/s $\color{#35bf28}+0.28\%$
test_transformed 0.6792s 0.6125s 1.6326 Ops/s 1.6531 Ops/s $\color{#d91a1a}-1.24\%$
test_serial 1.4144s 1.3635s 0.7334 Ops/s 0.7363 Ops/s $\color{#d91a1a}-0.39\%$
test_parallel 1.2633s 1.2089s 0.8272 Ops/s 0.8220 Ops/s $\color{#35bf28}+0.64\%$
test_step_mdp_speed[True-True-True-True-True] 0.1094ms 21.2921μs 46.9657 KOps/s 47.5695 KOps/s $\color{#d91a1a}-1.27\%$
test_step_mdp_speed[True-True-True-True-False] 41.3870μs 12.9641μs 77.1362 KOps/s 78.0809 KOps/s $\color{#d91a1a}-1.21\%$
test_step_mdp_speed[True-True-True-False-True] 37.2490μs 12.4541μs 80.2946 KOps/s 81.1455 KOps/s $\color{#d91a1a}-1.05\%$
test_step_mdp_speed[True-True-True-False-False] 29.7050μs 7.6307μs 131.0495 KOps/s 133.7546 KOps/s $\color{#d91a1a}-2.02\%$
test_step_mdp_speed[True-True-False-True-True] 59.1300μs 22.7418μs 43.9720 KOps/s 44.3838 KOps/s $\color{#d91a1a}-0.93\%$
test_step_mdp_speed[True-True-False-True-False] 72.9860μs 14.1453μs 70.6949 KOps/s 71.5656 KOps/s $\color{#d91a1a}-1.22\%$
test_step_mdp_speed[True-True-False-False-True] 31.3890μs 13.7099μs 72.9398 KOps/s 72.9538 KOps/s $\color{#d91a1a}-0.02\%$
test_step_mdp_speed[True-True-False-False-False] 32.5610μs 8.7366μs 114.4612 KOps/s 114.9790 KOps/s $\color{#d91a1a}-0.45\%$
test_step_mdp_speed[True-False-True-True-True] 54.3220μs 23.9930μs 41.6788 KOps/s 42.1187 KOps/s $\color{#d91a1a}-1.04\%$
test_step_mdp_speed[True-False-True-True-False] 34.7750μs 15.5806μs 64.1823 KOps/s 65.9234 KOps/s $\color{#d91a1a}-2.64\%$
test_step_mdp_speed[True-False-True-False-True] 0.2443ms 14.4638μs 69.1382 KOps/s 74.3347 KOps/s $\textbf{\color{#d91a1a}-6.99\%}$
test_step_mdp_speed[True-False-True-False-False] 31.4990μs 8.7824μs 113.8642 KOps/s 116.4862 KOps/s $\color{#d91a1a}-2.25\%$
test_step_mdp_speed[True-False-False-True-True] 55.0530μs 25.2641μs 39.5818 KOps/s 40.6965 KOps/s $\color{#d91a1a}-2.74\%$
test_step_mdp_speed[True-False-False-True-False] 56.5650μs 16.8473μs 59.3565 KOps/s 60.8938 KOps/s $\color{#d91a1a}-2.52\%$
test_step_mdp_speed[True-False-False-False-True] 38.6420μs 14.8028μs 67.5550 KOps/s 69.2780 KOps/s $\color{#d91a1a}-2.49\%$
test_step_mdp_speed[True-False-False-False-False] 40.2450μs 9.9749μs 100.2513 KOps/s 102.4222 KOps/s $\color{#d91a1a}-2.12\%$
test_step_mdp_speed[False-True-True-True-True] 56.4960μs 24.1700μs 41.3736 KOps/s 42.4621 KOps/s $\color{#d91a1a}-2.56\%$
test_step_mdp_speed[False-True-True-True-False] 38.0310μs 15.5119μs 64.4666 KOps/s 65.3643 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-True-True-False-True] 41.9480μs 15.9796μs 62.5799 KOps/s 64.1024 KOps/s $\color{#d91a1a}-2.38\%$
test_step_mdp_speed[False-True-True-False-False] 30.9080μs 10.0054μs 99.9460 KOps/s 101.8798 KOps/s $\color{#d91a1a}-1.90\%$
test_step_mdp_speed[False-True-False-True-True] 61.9460μs 24.8045μs 40.3153 KOps/s 40.7844 KOps/s $\color{#d91a1a}-1.15\%$
test_step_mdp_speed[False-True-False-True-False] 61.9660μs 16.6811μs 59.9480 KOps/s 60.7261 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[False-True-False-False-True] 45.4250μs 17.0660μs 58.5962 KOps/s 58.9393 KOps/s $\color{#d91a1a}-0.58\%$
test_step_mdp_speed[False-True-False-False-False] 43.3010μs 11.2643μs 88.7758 KOps/s 90.5894 KOps/s $\color{#d91a1a}-2.00\%$
test_step_mdp_speed[False-False-True-True-True] 77.6450μs 26.4511μs 37.8057 KOps/s 38.0973 KOps/s $\color{#d91a1a}-0.77\%$
test_step_mdp_speed[False-False-True-True-False] 66.9550μs 18.1544μs 55.0831 KOps/s 55.3806 KOps/s $\color{#d91a1a}-0.54\%$
test_step_mdp_speed[False-False-True-False-True] 40.0450μs 17.0280μs 58.7269 KOps/s 59.2243 KOps/s $\color{#d91a1a}-0.84\%$
test_step_mdp_speed[False-False-True-False-False] 31.3290μs 11.2832μs 88.6277 KOps/s 90.0302 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[False-False-False-True-True] 63.4390μs 27.4460μs 36.4352 KOps/s 36.9677 KOps/s $\color{#d91a1a}-1.44\%$
test_step_mdp_speed[False-False-False-True-False] 46.1870μs 19.0771μs 52.4190 KOps/s 52.6602 KOps/s $\color{#d91a1a}-0.46\%$
test_step_mdp_speed[False-False-False-False-True] 55.7440μs 18.1757μs 55.0185 KOps/s 56.4944 KOps/s $\color{#d91a1a}-2.61\%$
test_step_mdp_speed[False-False-False-False-False] 39.6840μs 12.4762μs 80.1529 KOps/s 83.1743 KOps/s $\color{#d91a1a}-3.63\%$
test_values[generalized_advantage_estimate-True-True] 10.7496ms 9.5348ms 104.8791 Ops/s 103.4995 Ops/s $\color{#35bf28}+1.33\%$
test_values[vec_generalized_advantage_estimate-True-True] 37.7916ms 35.0893ms 28.4987 Ops/s 28.6500 Ops/s $\color{#d91a1a}-0.53\%$
test_values[td0_return_estimate-False-False] 0.2237ms 0.1642ms 6.0902 KOps/s 5.9309 KOps/s $\color{#35bf28}+2.69\%$
test_values[td1_return_estimate-False-False] 26.7328ms 23.5938ms 42.3841 Ops/s 42.1664 Ops/s $\color{#35bf28}+0.52\%$
test_values[vec_td1_return_estimate-False-False] 36.2558ms 35.0972ms 28.4923 Ops/s 28.4343 Ops/s $\color{#35bf28}+0.20\%$
test_values[td_lambda_return_estimate-True-False] 37.2982ms 33.9813ms 29.4280 Ops/s 29.4622 Ops/s $\color{#d91a1a}-0.12\%$
test_values[vec_td_lambda_return_estimate-True-False] 36.3309ms 35.1094ms 28.4824 Ops/s 28.5566 Ops/s $\color{#d91a1a}-0.26\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 10.8762ms 8.2035ms 121.8986 Ops/s 122.3031 Ops/s $\color{#d91a1a}-0.33\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 2.2669ms 1.8623ms 536.9847 Ops/s 540.2060 Ops/s $\color{#d91a1a}-0.60\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4197ms 0.3457ms 2.8926 KOps/s 2.8533 KOps/s $\color{#35bf28}+1.38\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 48.9323ms 45.7189ms 21.8728 Ops/s 22.4341 Ops/s $\color{#d91a1a}-2.50\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 3.6559ms 3.0327ms 329.7372 Ops/s 328.6587 Ops/s $\color{#35bf28}+0.33\%$
test_dqn_speed 82.0240ms 6.3922ms 156.4411 Ops/s 175.6906 Ops/s $\textbf{\color{#d91a1a}-10.96\%}$
test_ddpg_speed 13.4634ms 11.4796ms 87.1110 Ops/s 90.1932 Ops/s $\color{#d91a1a}-3.42\%$
test_sac_speed 25.5287ms 23.3495ms 42.8275 Ops/s 43.4466 Ops/s $\color{#d91a1a}-1.42\%$
test_redq_speed 20.0596ms 14.2849ms 70.0038 Ops/s 69.0498 Ops/s $\color{#35bf28}+1.38\%$
test_redq_deprec_speed 31.6303ms 23.2626ms 42.9874 Ops/s 45.9461 Ops/s $\textbf{\color{#d91a1a}-6.44\%}$
test_td3_speed 24.7313ms 16.5373ms 60.4694 Ops/s 62.2669 Ops/s $\color{#d91a1a}-2.89\%$
test_cql_speed 76.7956ms 74.4192ms 13.4374 Ops/s 13.9455 Ops/s $\color{#d91a1a}-3.64\%$
test_a2c_speed 24.2130ms 21.7954ms 45.8813 Ops/s 46.6429 Ops/s $\color{#d91a1a}-1.63\%$
test_ppo_speed 23.6205ms 22.5441ms 44.3574 Ops/s 46.4073 Ops/s $\color{#d91a1a}-4.42\%$
test_reinforce_speed 22.3030ms 21.5408ms 46.4236 Ops/s 48.3337 Ops/s $\color{#d91a1a}-3.95\%$
test_iql_speed 58.3857ms 55.5467ms 18.0029 Ops/s 18.0508 Ops/s $\color{#d91a1a}-0.27\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.2997ms 2.7950ms 357.7843 Ops/s 358.8915 Ops/s $\color{#d91a1a}-0.31\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.8160ms 0.5156ms 1.9395 KOps/s 1.9698 KOps/s $\color{#d91a1a}-1.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6156ms 0.4843ms 2.0646 KOps/s 2.0838 KOps/s $\color{#d91a1a}-0.92\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.3095ms 2.8151ms 355.2251 Ops/s 363.8795 Ops/s $\color{#d91a1a}-2.38\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8294ms 0.5071ms 1.9722 KOps/s 2.0024 KOps/s $\color{#d91a1a}-1.51\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7500ms 0.4777ms 2.0934 KOps/s 2.1084 KOps/s $\color{#d91a1a}-0.71\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.3628ms 2.7278ms 366.5900 Ops/s 403.9235 Ops/s $\textbf{\color{#d91a1a}-9.24\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.7346ms 0.6242ms 1.6020 KOps/s 1.6169 KOps/s $\color{#d91a1a}-0.92\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9174ms 0.6089ms 1.6422 KOps/s 1.6808 KOps/s $\color{#d91a1a}-2.30\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.5920ms 2.7805ms 359.6483 Ops/s 369.6914 Ops/s $\color{#d91a1a}-2.72\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9983ms 0.5154ms 1.9401 KOps/s 1.9721 KOps/s $\color{#d91a1a}-1.63\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5998ms 0.4868ms 2.0542 KOps/s 2.0935 KOps/s $\color{#d91a1a}-1.88\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 4.2541ms 2.8984ms 345.0173 Ops/s 360.1504 Ops/s $\color{#d91a1a}-4.20\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.8424ms 0.5148ms 1.9424 KOps/s 1.9822 KOps/s $\color{#d91a1a}-2.01\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6498ms 0.4801ms 2.0829 KOps/s 2.0796 KOps/s $\color{#35bf28}+0.16\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.0781ms 2.7462ms 364.1343 Ops/s 376.1795 Ops/s $\color{#d91a1a}-3.20\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 90.2541ms 0.7304ms 1.3692 KOps/s 1.6150 KOps/s $\textbf{\color{#d91a1a}-15.22\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.9221ms 0.6093ms 1.6411 KOps/s 1.6905 KOps/s $\color{#d91a1a}-2.92\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1106s 8.3420ms 119.8750 Ops/s 130.2649 Ops/s $\textbf{\color{#d91a1a}-7.98\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 15.4885ms 13.1434ms 76.0838 Ops/s 75.1057 Ops/s $\color{#35bf28}+1.30\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 4.3409ms 2.5188ms 397.0214 Ops/s 394.8569 Ops/s $\color{#35bf28}+0.55\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1139s 9.8926ms 101.0859 Ops/s 121.6467 Ops/s $\textbf{\color{#d91a1a}-16.90\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 15.7419ms 13.2320ms 75.5744 Ops/s 63.8764 Ops/s $\textbf{\color{#35bf28}+18.31\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 4.5910ms 2.5182ms 397.1029 Ops/s 392.7891 Ops/s $\color{#35bf28}+1.10\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1145s 8.7709ms 114.0132 Ops/s 118.0962 Ops/s $\color{#d91a1a}-3.46\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 15.9810ms 13.2117ms 75.6905 Ops/s 73.6741 Ops/s $\color{#35bf28}+2.74\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 4.6892ms 2.6913ms 371.5619 Ops/s 363.7671 Ops/s $\color{#35bf28}+2.14\%$

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of GPU Benchmark Tests

Total Benchmarks: 92. Improved: $\large\color{#35bf28}4$. Worsened: $\large\color{#d91a1a}3$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_single 0.1200s 0.1187s 8.4253 Ops/s 8.3742 Ops/s $\color{#35bf28}+0.61\%$
test_sync 0.1367s 0.1352s 7.3945 Ops/s 7.3832 Ops/s $\color{#35bf28}+0.15\%$
test_async 0.2718s 0.1327s 7.5368 Ops/s 7.6298 Ops/s $\color{#d91a1a}-1.22\%$
test_single_pixels 0.1419s 0.1415s 7.0647 Ops/s 7.0801 Ops/s $\color{#d91a1a}-0.22\%$
test_sync_pixels 0.1022s 0.1005s 9.9512 Ops/s 9.9664 Ops/s $\color{#d91a1a}-0.15\%$
test_async_pixels 0.2666s 96.3105ms 10.3831 Ops/s 10.5509 Ops/s $\color{#d91a1a}-1.59\%$
test_simple 0.9635s 0.8832s 1.1322 Ops/s 1.1461 Ops/s $\color{#d91a1a}-1.21\%$
test_transformed 1.1872s 1.1175s 0.8948 Ops/s 0.8889 Ops/s $\color{#35bf28}+0.67\%$
test_serial 2.3869s 2.3810s 0.4200 Ops/s 0.4123 Ops/s $\color{#35bf28}+1.86\%$
test_parallel 3.3787s 3.2096s 0.3116 Ops/s 0.3135 Ops/s $\color{#d91a1a}-0.62\%$
test_step_mdp_speed[True-True-True-True-True] 58.1010μs 32.1740μs 31.0810 KOps/s 30.3039 KOps/s $\color{#35bf28}+2.56\%$
test_step_mdp_speed[True-True-True-True-False] 43.3210μs 19.2394μs 51.9765 KOps/s 50.8223 KOps/s $\color{#35bf28}+2.27\%$
test_step_mdp_speed[True-True-True-False-True] 42.5710μs 17.8881μs 55.9032 KOps/s 54.1451 KOps/s $\color{#35bf28}+3.25\%$
test_step_mdp_speed[True-True-True-False-False] 25.1700μs 10.9234μs 91.5464 KOps/s 88.7005 KOps/s $\color{#35bf28}+3.21\%$
test_step_mdp_speed[True-True-False-True-True] 66.6810μs 33.2993μs 30.0306 KOps/s 29.1453 KOps/s $\color{#35bf28}+3.04\%$
test_step_mdp_speed[True-True-False-True-False] 44.6310μs 20.9257μs 47.7882 KOps/s 46.5619 KOps/s $\color{#35bf28}+2.63\%$
test_step_mdp_speed[True-True-False-False-True] 92.6020μs 19.6943μs 50.7761 KOps/s 49.3693 KOps/s $\color{#35bf28}+2.85\%$
test_step_mdp_speed[True-True-False-False-False] 33.5900μs 12.6522μs 79.0377 KOps/s 76.3189 KOps/s $\color{#35bf28}+3.56\%$
test_step_mdp_speed[True-False-True-True-True] 64.3010μs 35.3916μs 28.2553 KOps/s 27.6762 KOps/s $\color{#35bf28}+2.09\%$
test_step_mdp_speed[True-False-True-True-False] 47.2900μs 23.1953μs 43.1122 KOps/s 42.5555 KOps/s $\color{#35bf28}+1.31\%$
test_step_mdp_speed[True-False-True-False-True] 39.5410μs 20.0679μs 49.8307 KOps/s 49.3094 KOps/s $\color{#35bf28}+1.06\%$
test_step_mdp_speed[True-False-True-False-False] 35.5800μs 12.7490μs 78.4378 KOps/s 76.2510 KOps/s $\color{#35bf28}+2.87\%$
test_step_mdp_speed[True-False-False-True-True] 64.5710μs 37.4044μs 26.7348 KOps/s 26.0792 KOps/s $\color{#35bf28}+2.51\%$
test_step_mdp_speed[True-False-False-True-False] 45.8610μs 24.6201μs 40.6172 KOps/s 39.7274 KOps/s $\color{#35bf28}+2.24\%$
test_step_mdp_speed[True-False-False-False-True] 38.5100μs 21.4366μs 46.6493 KOps/s 45.7010 KOps/s $\color{#35bf28}+2.07\%$
test_step_mdp_speed[True-False-False-False-False] 31.0710μs 14.6790μs 68.1244 KOps/s 66.7991 KOps/s $\color{#35bf28}+1.98\%$
test_step_mdp_speed[False-True-True-True-True] 63.3010μs 35.7848μs 27.9449 KOps/s 27.3852 KOps/s $\color{#35bf28}+2.04\%$
test_step_mdp_speed[False-True-True-True-False] 53.9010μs 23.3600μs 42.8081 KOps/s 42.6625 KOps/s $\color{#35bf28}+0.34\%$
test_step_mdp_speed[False-True-True-False-True] 44.4800μs 23.7934μs 42.0284 KOps/s 41.2371 KOps/s $\color{#35bf28}+1.92\%$
test_step_mdp_speed[False-True-True-False-False] 31.3610μs 14.5920μs 68.5305 KOps/s 66.1464 KOps/s $\color{#35bf28}+3.60\%$
test_step_mdp_speed[False-True-False-True-True] 64.4210μs 37.0944μs 26.9582 KOps/s 26.0301 KOps/s $\color{#35bf28}+3.57\%$
test_step_mdp_speed[False-True-False-True-False] 43.8410μs 24.8563μs 40.2313 KOps/s 39.5682 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[False-True-False-False-True] 52.1210μs 25.9279μs 38.5684 KOps/s 38.6780 KOps/s $\color{#d91a1a}-0.28\%$
test_step_mdp_speed[False-True-False-False-False] 75.2510μs 16.4314μs 60.8591 KOps/s 59.3531 KOps/s $\color{#35bf28}+2.54\%$
test_step_mdp_speed[False-False-True-True-True] 67.9410μs 39.6282μs 25.2345 KOps/s 24.7796 KOps/s $\color{#35bf28}+1.84\%$
test_step_mdp_speed[False-False-True-True-False] 44.5210μs 26.9314μs 37.1314 KOps/s 36.5174 KOps/s $\color{#35bf28}+1.68\%$
test_step_mdp_speed[False-False-True-False-True] 45.6410μs 25.4672μs 39.2661 KOps/s 38.3536 KOps/s $\color{#35bf28}+2.38\%$
test_step_mdp_speed[False-False-True-False-False] 40.4800μs 16.2595μs 61.5026 KOps/s 59.5763 KOps/s $\color{#35bf28}+3.23\%$
test_step_mdp_speed[False-False-False-True-True] 67.7710μs 40.6664μs 24.5904 KOps/s 24.1400 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[False-False-False-True-False] 45.4610μs 28.5138μs 35.0707 KOps/s 34.7747 KOps/s $\color{#35bf28}+0.85\%$
test_step_mdp_speed[False-False-False-False-True] 49.0110μs 27.2863μs 36.6485 KOps/s 36.2042 KOps/s $\color{#35bf28}+1.23\%$
test_step_mdp_speed[False-False-False-False-False] 36.4610μs 18.0629μs 55.3620 KOps/s 53.6734 KOps/s $\color{#35bf28}+3.15\%$
test_values[generalized_advantage_estimate-True-True] 26.3858ms 25.9707ms 38.5049 Ops/s 39.9323 Ops/s $\color{#d91a1a}-3.57\%$
test_values[vec_generalized_advantage_estimate-True-True] 87.7293ms 3.3187ms 301.3255 Ops/s 302.3957 Ops/s $\color{#d91a1a}-0.35\%$
test_values[td0_return_estimate-False-False] 98.7310μs 62.6188μs 15.9696 KOps/s 16.5983 KOps/s $\color{#d91a1a}-3.79\%$
test_values[td1_return_estimate-False-False] 56.1432ms 54.8677ms 18.2257 Ops/s 18.7607 Ops/s $\color{#d91a1a}-2.85\%$
test_values[vec_td1_return_estimate-False-False] 1.9951ms 1.7573ms 569.0664 Ops/s 569.1410 Ops/s $\color{#d91a1a}-0.01\%$
test_values[td_lambda_return_estimate-True-False] 88.5854ms 85.1895ms 11.7385 Ops/s 11.7629 Ops/s $\color{#d91a1a}-0.21\%$
test_values[vec_td_lambda_return_estimate-True-False] 4.0871ms 1.7951ms 557.0748 Ops/s 553.1847 Ops/s $\color{#35bf28}+0.70\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 23.6878ms 23.4287ms 42.6827 Ops/s 42.4427 Ops/s $\color{#35bf28}+0.57\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 0.9117ms 0.7004ms 1.4278 KOps/s 1.4263 KOps/s $\color{#35bf28}+0.10\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.7152ms 0.6510ms 1.5362 KOps/s 1.5506 KOps/s $\color{#d91a1a}-0.93\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 1.4870ms 1.4489ms 690.1915 Ops/s 690.6554 Ops/s $\color{#d91a1a}-0.07\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 0.9776ms 0.6737ms 1.4843 KOps/s 1.5167 KOps/s $\color{#d91a1a}-2.14\%$
test_dqn_speed 8.5238ms 7.0350ms 142.1465 Ops/s 137.2409 Ops/s $\color{#35bf28}+3.57\%$
test_ddpg_speed 14.2314ms 13.4400ms 74.4046 Ops/s 70.9768 Ops/s $\color{#35bf28}+4.83\%$
test_sac_speed 27.8255ms 26.9438ms 37.1143 Ops/s 35.8190 Ops/s $\color{#35bf28}+3.62\%$
test_redq_speed 12.9388ms 11.6181ms 86.0728 Ops/s 84.1782 Ops/s $\color{#35bf28}+2.25\%$
test_redq_deprec_speed 22.9337ms 21.9796ms 45.4968 Ops/s 40.7764 Ops/s $\textbf{\color{#35bf28}+11.58\%}$
test_td3_speed 18.3388ms 18.1083ms 55.2234 Ops/s 53.6244 Ops/s $\color{#35bf28}+2.98\%$
test_cql_speed 0.1820s 80.3677ms 12.4428 Ops/s 13.1559 Ops/s $\textbf{\color{#d91a1a}-5.42\%}$
test_a2c_speed 25.1505ms 24.0033ms 41.6609 Ops/s 39.8564 Ops/s $\color{#35bf28}+4.53\%$
test_ppo_speed 25.5235ms 24.5213ms 40.7809 Ops/s 39.8550 Ops/s $\color{#35bf28}+2.32\%$
test_reinforce_speed 24.2535ms 23.4206ms 42.6975 Ops/s 41.6025 Ops/s $\color{#35bf28}+2.63\%$
test_iql_speed 50.5707ms 49.2260ms 20.3145 Ops/s 19.8344 Ops/s $\color{#35bf28}+2.42\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.8699ms 3.6057ms 277.3409 Ops/s 272.0325 Ops/s $\color{#35bf28}+1.95\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7604ms 0.5685ms 1.7591 KOps/s 1.7526 KOps/s $\color{#35bf28}+0.37\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.7259ms 0.5461ms 1.8310 KOps/s 1.6022 KOps/s $\textbf{\color{#35bf28}+14.28\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.9167ms 3.6619ms 273.0798 Ops/s 269.2880 Ops/s $\color{#35bf28}+1.41\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7808ms 0.5550ms 1.8017 KOps/s 1.7643 KOps/s $\color{#35bf28}+2.12\%$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.7331ms 0.5311ms 1.8829 KOps/s 1.5435 KOps/s $\textbf{\color{#35bf28}+21.99\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.5076ms 3.3036ms 302.6969 Ops/s 295.8856 Ops/s $\color{#35bf28}+2.30\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8475ms 0.6866ms 1.4564 KOps/s 1.4462 KOps/s $\color{#35bf28}+0.70\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.1145s 0.7540ms 1.3262 KOps/s 1.4914 KOps/s $\textbf{\color{#d91a1a}-11.07\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 3.6874ms 3.5497ms 281.7151 Ops/s 269.8195 Ops/s $\color{#35bf28}+4.41\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.7209ms 0.5697ms 1.7552 KOps/s 1.7543 KOps/s $\color{#35bf28}+0.05\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6712ms 0.5477ms 1.8257 KOps/s 1.8374 KOps/s $\color{#d91a1a}-0.64\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 3.8722ms 3.6469ms 274.2029 Ops/s 270.0643 Ops/s $\color{#35bf28}+1.53\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7469ms 0.5595ms 1.7872 KOps/s 1.7711 KOps/s $\color{#35bf28}+0.91\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6612ms 0.5389ms 1.8557 KOps/s 1.8456 KOps/s $\color{#35bf28}+0.55\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 3.4633ms 3.2710ms 305.7182 Ops/s 298.4705 Ops/s $\color{#35bf28}+2.43\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.9170ms 0.6911ms 1.4470 KOps/s 1.4398 KOps/s $\color{#35bf28}+0.50\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8771ms 0.6646ms 1.5047 KOps/s 1.4859 KOps/s $\color{#35bf28}+1.26\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.1313s 12.5955ms 79.3935 Ops/s 93.3633 Ops/s $\textbf{\color{#d91a1a}-14.96\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 18.6035ms 15.9212ms 62.8092 Ops/s 61.8443 Ops/s $\color{#35bf28}+1.56\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 6.5714ms 3.1659ms 315.8648 Ops/s 316.2598 Ops/s $\color{#d91a1a}-0.12\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.1321s 10.4916ms 95.3141 Ops/s 96.6455 Ops/s $\color{#d91a1a}-1.38\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 18.4474ms 16.0207ms 62.4194 Ops/s 53.9099 Ops/s $\textbf{\color{#35bf28}+15.78\%}$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.7922ms 3.1211ms 320.3999 Ops/s 314.4270 Ops/s $\color{#35bf28}+1.90\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.1257s 10.5399ms 94.8773 Ops/s 92.7630 Ops/s $\color{#35bf28}+2.28\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 18.5602ms 16.1992ms 61.7313 Ops/s 61.0234 Ops/s $\color{#35bf28}+1.16\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 7.7907ms 3.3495ms 298.5544 Ops/s 294.6392 Ops/s $\color{#35bf28}+1.33\%$

@vmoens vmoens added the Refactoring Refactoring of an existing feature label Jan 31, 2024
@vmoens vmoens added Environments Adds or modifies an environment wrapper Data Data-related PR, will launch data-related jobs labels Jan 31, 2024
@vmoens vmoens mentioned this pull request Jan 31, 2024
Closed
@vmoens vmoens merged commit b5e90c4 into main Jan 31, 2024
62 of 66 checks passed
@vmoens vmoens deleted the remove-deprecs branch January 31, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobettini matteobettini matteobettini left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Data Data-related PR, will launch data-related jobs Environments Adds or modifies an environment wrapper Refactoring Refactoring of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmoens @matteobettini @facebook-github-bot