Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix warning call #1857

Closed
wants to merge 1 commit into from

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Jan 31, 2024

Deprecation warnings are usually called with

warnings.warn(

This PR modifies the warning in

logging.warning(
to the right syntax, as the current call will not expect the category attribute

Copy link

pytorch-bot bot commented Jan 31, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/1857

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2024
@vmoens
Copy link
Contributor

vmoens commented Jan 31, 2024

part of #1820

@vmoens vmoens closed this Jan 31, 2024
@matteobettini matteobettini deleted the fix-logging branch February 22, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants