Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for eventlet/gevent monkey patching #3140

Merged
merged 4 commits into from
Nov 24, 2024
+8 −0
Merged

Improve error message for eventlet/gevent monkey patching #3140

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66bb89a
Improve error message for eventlet/gevent monkey patching
A5rocks Nov 19, 2024
da0657d
Add a newsfragment
A5rocks Nov 19, 2024
2e388e5
Update src/trio/_core/_run.py
A5rocks Nov 23, 2024
5e01bf0
Clean up a bit
A5rocks Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/3087.doc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Improve error message when run after gevent's monkey patching.
7 changes: 6 additions & 1 deletion src/trio/_core/_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2953,7 +2953,12 @@ async def checkpoint_if_cancelled() -> None:
_KqueueStatistics as IOStatistics,
)
else: # pragma: no cover
raise NotImplementedError("unsupported platform")
if "eventlet" in sys.modules or "gevent" in sys.modules:
raise NotImplementedError(
"unsupported platform or primitives trio depends on are monkey-patched out",
)
else:
raise NotImplementedError("unsupported platform")
A5rocks marked this conversation as resolved.
Show resolved Hide resolved

from ._generated_instrumentation import *
from ._generated_run import *
Loading