-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for eventlet/gevent monkey patching #3140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also unable to test myself, but looks good as far as I can tell
@yurivict would you mind testing this to make sure the better error message appears? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the error message could be improved by saying which patchers are present, I'll suggest a change
Co-authored-by: Thomas Grainger <[email protected]>
de61f00
to
5e01bf0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3140 +/- ##
========================================
Coverage 99.62% 99.63%
========================================
Files 122 122
Lines 18360 18765 +405
Branches 1222 1280 +58
========================================
+ Hits 18291 18696 +405
Misses 47 47
Partials 22 22
|
Fixes #3087
Unfortunately I am unable to check this because I only have Linux and Windows available. This only happens on MacOS.