Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for eventlet/gevent monkey patching #3140

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Nov 19, 2024

Fixes #3087

Unfortunately I am unable to check this because I only have Linux and Windows available. This only happens on MacOS.

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also unable to test myself, but looks good as far as I can tell

@A5rocks
Copy link
Contributor Author

A5rocks commented Nov 19, 2024

@yurivict would you mind testing this to make sure the better error message appears?

Copy link
Member

@graingert graingert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error message could be improved by saying which patchers are present, I'll suggest a change

src/trio/_core/_run.py Outdated Show resolved Hide resolved
@graingert graingert dismissed their stale review November 21, 2024 10:02

my review should not be blocking

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (f724be5) to head (5e01bf0).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3140    +/-   ##
========================================
  Coverage   99.62%   99.63%            
========================================
  Files         122      122            
  Lines       18360    18765   +405     
  Branches     1222     1280    +58     
========================================
+ Hits        18291    18696   +405     
  Misses         47       47            
  Partials       22       22            
Files with missing lines Coverage Δ
src/trio/_core/_run.py 99.02% <ø> (ø)

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@A5rocks A5rocks merged commit 7d9c4a6 into python-trio:main Nov 24, 2024
38 checks passed
@A5rocks A5rocks deleted the better-error-message branch November 24, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run-time failure on FreeBSD: NotImplementedError: unsupported platform
3 participants