Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: NEP29 Apr 2024, zenodo updates #227

Merged
merged 39 commits into from
Jul 8, 2024
Merged

MAINT: NEP29 Apr 2024, zenodo updates #227

merged 39 commits into from
Jul 8, 2024

Conversation

jklenzing
Copy link
Member

Description

  • Updates NEP29 standards for Apr 5, 2024.
  • Updates zenodo -> author order, institutions, keywords

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

via GitHub Actions main.yml

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing
Copy link
Member Author

Note that test failures caused in part by pysat/pysat#1196

@jklenzing
Copy link
Member Author

Adding the "new_test" flag to dmsp_ssusi fixes the memory issue. The remaining issue is in pysat. Could comment out the clean_warn flags with an issue to fix for the next release.

@jklenzing jklenzing requested a review from aburrell April 10, 2024 15:59
@jklenzing
Copy link
Member Author

Pinging @aburrell for comments on the path forward

@aburrell
Copy link
Member

Adding the "new_test" flag to dmsp_ssusi fixes the memory issue. The remaining issue is in pysat. Could comment out the clean_warn flags with an issue to fix for the next release.

This seems like the best path forward.

@jklenzing
Copy link
Member Author

So.... tests for python 3.10 and 3.12 work on ubuntu, and tests for 3.11 work on windows, and everything else is failing with some sort of netCDF4 / HDF error. This particular combination is failing consistently.

@jklenzing jklenzing mentioned this pull request Jun 13, 2024
11 tasks
@aburrell
Copy link
Member

Can we "allow fail" for the Ops tests?

@jklenzing
Copy link
Member Author

NOTE: test_w_pad now fails for maven_sep, presumably due to new xarray releases. Documented in #222.

@aburrell
Copy link
Member

Looks like you may need to update coveralls to use Coveralls Actions or follow the steps I took at OCBPy.

@jklenzing jklenzing added this to the 0.0.6 Release milestone Jun 17, 2024
Switch to coveralls app from coveralls action.
Attempt to fix yaml syntax.
Another attempt to fix yaml syntax.
Re-added `steps` to yaml.
Added a missing if statement to the yaml and fixed some of the step names.
Fixed the name of the GitHub secret.
Specify the coverage file in the macOS call.
Coveralls app isn't working on mac, no idea why.  Checking that coverage file exists.
Use the Coveralls Repository Token, which I just added to the GitHub repository.
Try specifying the format for the MacOS coverage call.
Try removing as many options as possible.
Put coveralls in verbose mode in preparation for help call.
Specify coverage xml output.
Remove the tabs from the yaml.
Fix the name of the xml to reflect reality instead of the docs.
@aburrell
Copy link
Member

Since the coveralls coverage-reporter is failing regardless of what I do, I have asked support for their help.

Made changes suggested by James from Coveralls.
Added a debug statement, as suggested for better feedback.
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend we open an issue for the Mac Coveralls failure and move on with our development.

@jklenzing jklenzing mentioned this pull request Jul 8, 2024
.github/workflows/main.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jklenzing
Copy link
Member Author

Added #232 to cover the open issue. Also tweaked the minimum numpy version for the June 2024 update.

@jklenzing jklenzing merged commit 5005613 into develop Jul 8, 2024
17 of 23 checks passed
@jklenzing jklenzing deleted the maint/nep29_apr24 branch July 18, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants