-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: NEP29 Apr 2024, zenodo updates #227
Conversation
Note that test failures caused in part by pysat/pysat#1196 |
Adding the "new_test" flag to dmsp_ssusi fixes the memory issue. The remaining issue is in pysat. Could comment out the clean_warn flags with an issue to fix for the next release. |
Pinging @aburrell for comments on the path forward |
This seems like the best path forward. |
So.... tests for python 3.10 and 3.12 work on ubuntu, and tests for 3.11 work on windows, and everything else is failing with some sort of netCDF4 / HDF error. This particular combination is failing consistently. |
Can we "allow fail" for the Ops tests? |
NOTE: test_w_pad now fails for maven_sep, presumably due to new xarray releases. Documented in #222. |
Looks like you may need to update coveralls to use Coveralls Actions or follow the steps I took at OCBPy. |
Switch to coveralls app from coveralls action.
Attempt to fix yaml syntax.
Another attempt to fix yaml syntax.
Re-added `steps` to yaml.
Added a missing if statement to the yaml and fixed some of the step names.
Fixed the name of the GitHub secret.
Specify the coverage file in the macOS call.
Coveralls app isn't working on mac, no idea why. Checking that coverage file exists.
Use the Coveralls Repository Token, which I just added to the GitHub repository.
Try specifying the format for the MacOS coverage call.
Try removing as many options as possible.
This reverts commit e35b977.
Put coveralls in verbose mode in preparation for help call.
Specify coverage xml output.
Remove the tabs from the yaml.
Fix the name of the xml to reflect reality instead of the docs.
Since the coveralls coverage-reporter is failing regardless of what I do, I have asked support for their help. |
Made changes suggested by James from Coveralls.
Added a debug statement, as suggested for better feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend we open an issue for the Mac Coveralls failure and move on with our development.
Added #232 to cover the open issue. Also tweaked the minimum numpy version for the June 2024 update. |
Description
Type of change
How Has This Been Tested?
via GitHub Actions main.yml
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release