-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSUSI bug #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted the general portion of the GUVI `concat_data` method, to allow use in the DMSP SSUSI data.
Use the new JHU APL concat function in local method.
Use the JHU APL `concat_data` function in this Instrument.
Modified changelog to reflect changes in this pull request.
Updated the DMSP SSUSI test flags to only test for warnings in the clean routine when appropriate and to skip the new tests for the high resolution imaging data.
Tests still failing due to too much memory, add another skip.
Could you rebase into the #227 pull? That is the most functional branch and may fix the issues with test failure here |
Fixed a bug with roll-over hours.
jklenzing
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses an issue found when loading subsequent days of DMSP SSUSI SDR-Disk data, which caused a memory failure. Fixed by adding a custom
concat_data
method. This shares many lines of code with TIMED GUVI, so the comment elements were moved topysatNASA.instruments.methods.jhuapl
.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release