Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: backward compatibility for pysat #133

Merged
merged 4 commits into from
Oct 5, 2023
Merged

MAINT: backward compatibility for pysat #133

merged 4 commits into from
Oct 5, 2023

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Oct 5, 2023

Description

Addresses #112, #114, #123

The requirements file no has a minimum version of pysat 3.0.4.

  • Removing if/else statements and tests for older version of pysat.
  • Update location of load_netcdf

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

pytest

Test Configuration:

  • Operating system: Monterrey
  • Version number: Python 3.10.9

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing linked an issue Oct 5, 2023 that may be closed by this pull request
@jklenzing jklenzing marked this pull request as ready for review October 5, 2023 16:48
@jklenzing jklenzing merged commit a77c2c9 into develop Oct 5, 2023
15 of 19 checks passed
@jklenzing jklenzing deleted the maint/123 branch October 5, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants