Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TIE-GCM load support for pysat.utils.load_netCDF4 #114

Closed
aburrell opened this issue May 16, 2022 · 1 comment · Fixed by #133
Closed

Remove TIE-GCM load support for pysat.utils.load_netCDF4 #114

aburrell opened this issue May 16, 2022 · 1 comment · Fixed by #133
Assignees
Milestone

Comments

@aburrell
Copy link
Member

Is your feature request related to a problem? Please describe.
The location and name of the function to load netCDF data will soon change. This function is used by the UCAR TIE-GCM instrument in a direct call. At the moment, an if/else statement checks to see which call should be made.

Describe the solution you'd like
Not have if/else statements everywhere.

Describe alternatives you've considered
Adding a pysat version limit

Additional context
Eventually a pysat version limit will make sense, but for the moment, it's good to support any version of pysat 3.X.

@aburrell aburrell changed the title Remove TIE-GCM Remove TIE-GCM load support for pysat.utils.load_netCDF4 May 16, 2022
@aburrell aburrell added this to the 1.0.0 release milestone May 20, 2022
@jklenzing
Copy link
Member

This applies to sami2py and dineofs too.

@jklenzing jklenzing self-assigned this Oct 5, 2023
@jklenzing jklenzing linked a pull request Oct 5, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants