ruff format repo

[jGaboardi]

This MR:

• formats with repo with ruff standards -- only formatting -- no functional changes
• drops black and adds ruff to .pre-commit
• resolves swap from black to ruff for formatting #150
• resolves update pre-commit -- add ruff ; drop black #151

[codecov]

Codecov Report

Attention: Patch coverage is 57.81041% with 316 lines in your changes missing coverage. Please review.

Project coverage is 67.6%. Comparing base (d92edcb) to head (8a0969d).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
spreg/dgp.py	17.9%	69 Missing ⚠️
spreg/error_sp_regimes.py	48.6%	35 Missing and 1 partial ⚠️
spreg/error_sp.py	59.3%	20 Missing and 2 partials ⚠️
spreg/error_sp_het.py	48.6%	18 Missing and 1 partial ⚠️
spreg/utils.py	25.0%	16 Missing and 2 partials ⚠️
spreg/error_sp_hom.py	65.8%	12 Missing and 1 partial ⚠️
spreg/ols_regimes.py	38.1%	13 Missing ⚠️
spreg/error_sp_hom_regimes.py	72.7%	11 Missing and 1 partial ⚠️
spreg/twosls_sp_regimes.py	65.7%	11 Missing and 1 partial ⚠️
spreg/error_sp_het_regimes.py	75.0%	10 Missing and 1 partial ⚠️
... and 16 more

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #156   +/-   ##
=====================================
  Coverage   67.6%   67.6%           
=====================================
  Files         41      41           
  Lines       9622    9622           
  Branches    1433    1433           
=====================================
  Hits        6504    6504           
  Misses      2704    2704           
  Partials     414     414           

Files with missing lines	Coverage Δ
spreg/diagnostics.py	87.0% <100.0%> (ø)
spreg/diagnostics_panel.py	96.0% <100.0%> (ø)
spreg/diagnostics_sp.py	97.0% <100.0%> (ø)
spreg/diagnostics_sur.py	100.0% <100.0%> (ø)
spreg/diagnostics_tsls.py	87.9% <ø> (ø)
spreg/panel_fe.py	94.5% <ø> (ø)
spreg/panel_utils.py	49.2% <ø> (ø)
spreg/regimes.py	81.1% <100.0%> (ø)
spreg/sp_panels.py	87.0% <ø> (ø)
spreg/sur.py	76.8% <ø> (ø)
... and 27 more

[knaaptime]

this looks like a lot of changes, but it's nothing but formatting. Everything's passing. Will wait for @pedrovma's approval, but this is ready to merge

[jGaboardi]

@pedrovma After this PR is reviewed and merged (like @knaaptime mentioned, it's only formatting changes), I will get started with #155, which will be more involved. However, both standardized formatting and implementing linting will result in a much more maintainable codebase.

[pedrovma]

This is great. The issue here is just that several of these files have already been modified in the private GeoDa repo, so some of the new formatting may be lost. But I will do my best to merge them appropriately!
Many thanks, @jGaboardi!

[jGaboardi]

have already been modified in the private GeoDa repo

One thing you can do is also run ruff format spreg on the private repo side of things. That will make merging in much less painful later.

[martinfleis]

Just a question. Why do you have a private repo instead of developing in public like we do in any other package? It is super hard to make contributions to spreg if we don't know what is the current state of the codebase.

[lanselin]

That's by design. Pedro and I made that decision a long time ago to make development more efficient. The focus is on adding new methods and that is done most efficiently between the two of us without the overhead of the standard GitHub protocol. We're the gate keepers, so to speak. When the code is ready, it goes to the open repo, but for any substantive changes/contributions, people should contact us first.

[martinfleis]

Fair.

for any substantive changes/contributions, people should contact us first.

Shall we add a note on that to the Readme, so the contributing process is clear?

[lanselin]

Sure, great idea.