Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint repo with ruff -- pre-commit #155

Open
jGaboardi opened this issue Sep 1, 2024 · 4 comments
Open

lint repo with ruff -- pre-commit #155

jGaboardi opened this issue Sep 1, 2024 · 4 comments
Assignees

Comments

@jGaboardi
Copy link
Member

ensure spreg is actually being linted with ruff via .pre-commit

@jGaboardi jGaboardi self-assigned this Sep 1, 2024
@jGaboardi
Copy link
Member Author

Preliminary lint check found 1361 errors. I will likely be tackling the linting across multiple PRs.

@jGaboardi
Copy link
Member Author

@pedrovma Considering #156 (comment):

  1. Is this something you are interested in?
  2. If yes, would it help for me to put in 1 PR per file to ease the merging into the private branch?

In my opinion, this is something that spreg desperately needs to ensure maintainability into the future12

Footnotes

  1. currently 1533 warnings in dev

  2. currently 1361 items that need attention for linting

@pedrovma
Copy link
Member

pedrovma commented Sep 4, 2024

Hi @jGaboardi . I think individual PRs would be too much work. Luc and I are just finishing some tests and formatting for the release of version 1.7. It will be released by the end of this month. After the release, we can freeze the development in the private repo so you can work freely on the linting here. What do you think?

Many thanks.

@jGaboardi
Copy link
Member Author

Sure. That works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants