feat: add restrict well area #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fdrgsp
commented
Jul 10, 2024
•
fdrgsp
commented
- restrict well area
- test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 90.36% 90.40% +0.04%
==========================================
Files 73 73
Lines 8135 8171 +36
==========================================
+ Hits 7351 7387 +36
Misses 784 784 ☔ View full report in Codecov by Sentry. |
tlambert03
reviewed
Jul 11, 2024
src/pymmcore_widgets/useq_widgets/points_plans/_well_graphics_view.py
Outdated
Show resolved
Hide resolved
tlambert03
reviewed
Jul 11, 2024
src/pymmcore_widgets/useq_widgets/points_plans/_well_graphics_view.py
Outdated
Show resolved
Hide resolved
tlambert03
reviewed
Jul 11, 2024
src/pymmcore_widgets/useq_widgets/points_plans/_points_plan_widget.py
Outdated
Show resolved
Hide resolved
- Update the default width and height of the field of view (FOV) in the PointsPlanWidget to 300x200. - Remove the explicit setting of well size in the PointsPlanWidget initialization. Resolves: pymmcore-plus#123
|
@tlambert03 I'm done with the tests and are covering most of the widget. You can have a look if you want! |
|
not sure what's going on with that one 3.8 pyside2 test... not too worried, it's failing in #318 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.