-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional validation step (and documentation improvements) #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rest (in writer.py)
fsoubelet
added
Type: Feature
A (suggetion for a) new feature or enhancement in functionality.
To be discussed
Type: Documentation
Improvements, updates and fixes to the documentation.
labels
Jan 27, 2023
JoschD
reviewed
Jan 29, 2023
JoschD
reviewed
Jan 29, 2023
JoschD
reviewed
Jan 29, 2023
JoschD
reviewed
Jan 29, 2023
JoschD
approved these changes
Jan 30, 2023
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Documentation
Improvements, updates and fixes to the documentation.
Type: Feature
A (suggetion for a) new feature or enhancement in functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #106
The main changes are:
3.3.0
validate
boolean argument in the reader, which defaults toTrue
, enabling the user to skip the step.validate
boolean argument in the writer, which defaults toTrue
, enabling the user to skip the step.Worthy of noting:
This is a (very) significant speedup on large files. One can see a
x4
speedup reading a typical LHC model twiss without validation, and a~x11
speedup(!) on a 873M file (sliced fcc, 171k rows and 236 columns). See below a quick test.To be discussed:
On a side note, if someone know why the new documentation builds are weirdly expanding a lot in the index table of contents, I'd love to fix it too.