Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Speedup Dataframe Validation #108

Closed
fsoubelet opened this issue Jan 30, 2023 · 1 comment
Closed

[Feature Request]: Speedup Dataframe Validation #108

fsoubelet opened this issue Jan 30, 2023 · 1 comment
Assignees
@fsoubelet
Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.

Comments

@fsoubelet
Copy link
Member

Feature Description

As reported by some users, the validation step can be very slow on large dataframes (for instance sliced FCC lattice).

In #107 the validation step was made optional. This is a first step but it would be nice for users who wish to validate to be able to do so faster.

Possible Implementation

The main culprit is is_not_finite(x) in the validate function, which is slow and applied with applymap, also very slow.

This can be sped-up (see implementation).
@fsoubelet fsoubelet added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Minor labels Jan 30, 2023
@fsoubelet fsoubelet self-assigned this Jan 30, 2023
@fsoubelet fsoubelet mentioned this issue Jan 30, 2023
Merged
@fsoubelet
Copy link
Member Author

Closed by #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsoubelet fsoubelet

Labels
Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsoubelet