Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing missing arguments when opening zarr, hdf5 and netcdft4 datatrees #9428

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

aladinor
Copy link
Contributor

@aladinor aladinor commented Sep 3, 2024

@aladinor aladinor changed the title passing missing arguments to when opening hdf5 datatrees passing missing arguments to when opening hdf5 and netcdft4 datatrees Sep 4, 2024
@aladinor aladinor changed the title passing missing arguments to when opening hdf5 and netcdft4 datatrees passing missing arguments when opening hdf5 and netcdft4 datatrees Sep 4, 2024
@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Sep 7, 2024
Copy link
Contributor

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmuehlbauer or @keewis would you mind just confirming that this is the correct way to handle these kwargs?

@kmuehlbauer
Copy link
Contributor

@TomNicholas Yes, I think this is correct. I'm not sure if this can be restructured and would rely on @keewis expertise.

@keewis
Copy link
Collaborator

keewis commented Sep 20, 2024

sorry for the delay, I've been far away from any computer for the past two weeks.

I'd say short of adding the arguments to **kwargs that's the only thing we can do, as really we're just forwarding to open_groups_as_dict (which by the way I thought we wanted to call just open_groups? Maybe I missed some discussion on that).

@aladinor aladinor changed the title passing missing arguments when opening hdf5 and netcdft4 datatrees passing missing arguments when opening zarr, hdf5 and netcdft4 datatrees Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

arguments not passed to open_groups_as_dict function when opening a datatree
4 participants