Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix yield farming layouts and resize buttons to take full width #1793

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix yield farming layouts and resize buttons to take full width #1793

merged 1 commit into from
Aug 5, 2024

Conversation

kalashshah
Copy link
Member

Pull Request Template

Ticket Number

Description

Problem/Feature:

  • Fix yield farming layouts and resize buttons to take full width

Type of Change

  • Bug fix

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
Screenshot 2024-08-05 at 4 38 21 PM - **After:** What's changed now - Screenshot 2024-08-05 at 4 37 45 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@kalashshah kalashshah linked an issue Aug 5, 2024 that may be closed by this pull request
🐛 [BUG] - Yield Farming Layout and Buttons need a fix #1790
Closed
@kalashshah kalashshah self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

In YieldPushFeeV3.tsx:

  1. Line 366: <SkeletonLine width="164px"> is missing a closing tag </SkeletonLine>.
  2. Line 437: The ButtonsContainer component is not closed properly. It seems the closing </ButtonsContainer> tag is missing.
  3. Line 455: The StakingToolTip component has a prop assigned outside the component's scope. It should be moved inside with the proper syntax.
  4. Line 468: The StakingToolTip component is missing a closing tag </StakingToolTip>.
  5. Line 532: The styled component StakedAmount is not closed properly. It's missing a closing backtick.
  6. Line 533: The styled component EpochNo is missing the closing backtick.

In YieldUniswapV3.tsx:

  1. Line 439: The StakingToolTip component is not closed properly. It's missing a closing tag </StakingToolTip>.
  2. Line 446: The StakingToolTip component has a prop assigned outside the component's scope. It should be moved inside with the proper syntax.
  3. Line 489: The LoaderSpinner component has an invalid prop value (spinnerColor="#FFFFF"). It seems like a typo.
  4. Line 618: The styled component EpochNo is missing the closing backtick.

All other code seems to be okay.

Please make the necessary corrections to the mentioned issues.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-05 11:51 UTC

@rohitmalhotra1420 rohitmalhotra1420 merged commit 7a1049b into main Aug 5, 2024
2 of 3 checks passed
corlard3y pushed a commit that referenced this pull request Aug 14, 2024
@kalashshah @corlard3y
fix: yield farming layouts and resize buttons to take full width (#1793)
83ed985
rohitmalhotra1420 added a commit that referenced this pull request Sep 30, 2024
@corlard3y @mishramonalisha76
@rohitmalhotra1420 @kalashshah @abhishek-01k
Rewards V2 (#1772)
652e7f8 
* added loading colour

* add icon

* add components

* update styles

* update mobile view

* update titles

* change button labels

* update multiplier

* update useDailyRewards hook

* update unlock profile modal changes

* update usedailyrewards hook

* fix isLoading onclick

* update locked status/ rewards ui

* update new users status

* add skeleton loader

* comment out stake push activities

* update skeleton loader

* update locked icon

* format text

* feat: add alert ds component (#1781)

* feat: add alert ds component

* chore: update alert ds acc to review

* chore: update component acc to review

* update alert for error messages

* update indexes

* Update Dashboard.tsx

* remove unusued

* fixed review comments

* Update Button.tsx

* update completed state

* fixed the spinner and button

* fixed the spinner and button

* Added spinner component (#1783)

* added spinner component

* added review changes

* added correct variants

* added the review comments

* added the review comments

* Add progress bar to ds (#1787)

* feat: add progress bar to ds

* chore: update progress bar according to review

* add loading state

* update locked status

* update isLocked

* update loading state

* remove disabled state from button

* update locked divider

* update error message

* fix icons and illustrations

* update naming and imports

* update reward activites hook

* update type

* add types

* resolve conments

* update box

* update text changes

* update text

* update points real time

* update mutiplier conditions in bonus

* update gap

* update padding referal section

* adjust daily section ui

* update stake array

* update stake api

* update rewards verification hook

* fix: yield farming layouts and resize buttons to take full width (#1793)

* Add support for erc1155 (#1794)

* chore: add support for erc1155

* chore: update uiweb version to include erc1155 support

* Replaced older tab implementation in trending channels with the new tab block component (#1800)

* added

* moved function to utils

* tab changes

* reverted rewards tab change

* Update Dashboard.utils.ts

* Opt-In Dropdown for dashboard (#1802)

* Opt-In Dropdown for dashboard

* Fixed the comments and issues

* Fixed the context issue

* DS-Dapp Notification Component  (#1801)

* add in-app semantics and block files

* update notification component

* add localstorage identifier

* update library

* add duration option

* resolve comments

* update comment fixes

* fix comments

* testing notification

* update notification component

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* DApp-1804 tag component added in blocks (#1805)

* tag in progress

* implemented tag component

* Tag component implemented in blocks

* update hook and export component

* update code

* add componentdid mount flow

* update mount logic

* fix stake font size

* fix conflicts

* Fixed create channel ui , fixed message for unlock profile, removed governance from sidebar (#1817)

* fixed minor ui issues

* fixed minor ui issues

* fixed minor ui issues

* fixed select text color

* fixed select text color

* fixed select text color

* fixed chain issue

* fixed send notif delegate issue (#1822)

* fixed send notif delegate issue

* Fixed the send notification button on the navigation for delegatee list

* added fixes for alias

* added fixes for alias

* fixed review comment

---------

Co-authored-by: abhishek-01k <[email protected]>

* DApp-1799 blocks/table (#1824)

* table in progress

* in progress

* in progress

* table complete

* fixed header route +  reverted changes

* added alignment support

* set debug to false

* fix comments

* export type and fix issues

* update rewards notification

* fix loading state

* add activit days

* update locked status

* updates test whitelist file for nft claims

* fixed smart contract for alpha nft

* update reset time

* refactor code

* update fixes

* stake push

* update types

* update yarn.lock

* update icons

* update icons batch 2

* sort stake section

* add local storage key

* update hasEnded and has text

* fixed channel notifications (#1852)

* added the new monotone icons (#1857)

* added support for icons in tag components (#1853)

* update stat in yield farming data store (#1859)

* update refetch leaderboard

* fix double text issue - media query

* update icon

* hide notifs

* update font sizes

* fix invalid verification proof issue

* remove console

* update success flow

* fixes done

* removed the png file

* lock file fixed

* remove isActive Account in auth hook

---------

Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: rohitmalhotra1420 <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Abhishek <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@kalashshah kalashshah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Yield Farming Layout and Buttons need a fix
2 participants
@kalashshah @rohitmalhotra1420