Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Deploy Preview 🤝 meets 🤝 Github Pages #1527

Merged
merged 140 commits into from
May 20, 2024
Merged

Conversation

rohitmalhotra1420
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 commented May 15, 2024

Problem:

  • Earlier we were using vercel which could not deploy our PRs to it's platform. So we needed a solution to see our changes in live mode.

Solution:

  • I tried fixing it on vercel but the Out of Memory issue just won't give up even after maxing out the CPU size on vercel deployments.
  • So I used github actions and github pages to achieve the same.
  • The current implementation creates a build using github actions and deployed that build to the gh-pages branch under /pr-preview/pr-{prNumber} folder in the DApp repo itself.So our repo acts as a storage base for our builds.
  • We can create and store multiple builds for different PR in their respective folder because of this approach: /pr-preview/pr-{prNumber} .
  • For now the build will remain there forever, but we can change it in the future and also delete the build folders from the gh-pages branch manually.
  • A new github action workflow will be initiated once we open, reopen a PR or push changes to it.
  • The action will comment on the PR once and then update that single comment evertime we push new changes.
  • The preview build is similar to the dev env build.
  • It will be served on https://push-protocol.github.io/push-dapp/pr-preview/pr-{prNumber}/
  • A 404.html file has been added at the root of gh-pages branch to which fixes the reload issue of exact url (/pr-preview/pr-{prNumber}/channels) caused by github pages.

Additional Fixes:

  • Updated the yarn version for better compatibility and in future and avoiding yarn.lock issues.
  • Removed unused libraries.
  • Removed and fixed react import.
  • Removed unused imports.
  • Fixed assets path used from public or public/svg folder

@rohitmalhotra1420
Copy link
Collaborator Author

rohitmalhotra1420 commented May 20, 2024

  • when i reload the url it shows 404.
  • Some icons arent visible in channels page.
image * Chat page keeps on loading. * After connection wallet screen becomes blank * Yeild farming is also not loading. * Clicking on governance menu takes me to https://push-protocol.github.io/#/notavailable url and the page is 404.

@mishramonalisha76

  • Reload issue if fixed
  • Icons are visible now
  • Chat page works
  • Governance page was already working have checked it multiple times
  • Yield farming page is loading now
  • User is successfully able to connect wallet and use the app

Here is the updated link: https://push-protocol.github.io/push-dapp/pr-preview/pr-1527

@mishramonalisha76
Copy link
Collaborator

  • when i reload the url it shows 404.
  • Some icons arent visible in channels page.
image * Chat page keeps on loading. * After connection wallet screen becomes blank * Yeild farming is also not loading. * Clicking on governance menu takes me to https://push-protocol.github.io/#/notavailable url and the page is 404.

@mishramonalisha76

  • Reload issue if fixed
  • Icons are visible now
  • Chat page works
  • Governance page was already working have checked it multiple times
  • Yield farming page is loading now
  • User is successfully able to connect wallet and use the app

Here is the updated link: https://push-protocol.github.io/push-dapp/pr-preview/pr-1527

image image
  • the above icons still gives error.
  • if i am on mainet, it doesnot prompt metamask to switch the networ to sepolia.

@corlard3y
Copy link
Collaborator

@rohitmalhotra1420 On my end- apart from all errors already mentioned.

  • I cannot see the dashboard/create channel options. The links under the Developer section in the sidebar
    Screenshot 2024-05-20 at 12 16 18 1

Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corlard3y
Copy link
Collaborator

It's resolved now from my end - changes look good to me

corlard3y
corlard3y previously approved these changes May 20, 2024
@rohitmalhotra1420 rohitmalhotra1420 merged commit 66a13f5 into main May 20, 2024
2 of 4 checks passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue May 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a PR preview for push DApp
5 participants