Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECD] Bump OpenTitan for reduced memory and iDMA. #3

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

maicolciani
Copy link

@maicolciani maicolciani commented Mar 13, 2024

Bumping OpenTitan to a ligher version:

  • 32KB of SRAM and 64KB of emulated flash.
  • iDMA and TCDM integration, dedicated to cryptographic accelrators
  • integrated into carfield the new AXI4 port for opentitan's iDMA

Copy link
Collaborator

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments.

hw/carfield_pkg.sv Outdated Show resolved Hide resolved
hw/carfield.sv Outdated Show resolved Hide resolved
hw/carfield_pkg.sv Outdated Show resolved Hide resolved
carfield.mk Outdated Show resolved Hide resolved
hw/carfield.sv Outdated Show resolved Hide resolved
hw/carfield.sv Outdated Show resolved Hide resolved
carfield.mk Outdated Show resolved Hide resolved
hw/carfield.sv Outdated Show resolved Hide resolved
hw/carfield_pkg.sv Outdated Show resolved Hide resolved
hw/carfield_pkg.sv Outdated Show resolved Hide resolved
@maicolciani
Copy link
Author

Almost fixed all the comments. Still I get a test failing the CI, the CVA6 test with bootmode=3. I am debugging the issue.

@yvantor
Copy link
Collaborator

yvantor commented Mar 21, 2024

Almost fixed all the comments. Still I get a test failing the CI, the CVA6 test with bootmode=3. I am debugging the issue.

That one should be solved, it is probably just the server that got stuck due to many jobs running running in parallel.

@maicolciani
Copy link
Author

Almost fixed all the comments. Still I get a test failing the CI, the CVA6 test with bootmode=3. I am debugging the issue.

That one should be solved, it is probably just the server that got stuck due to many jobs running running in parallel.

I removed that parameters from islands_cfg_t as disucssed, indeed not needed. When CI finishes I think we can merge

@yvantor
Copy link
Collaborator

yvantor commented Mar 21, 2024

@maicolciani thank you! Can you also open a PR on the non free and there stretch a bit the timer for the boot tests? Maybe pushing it to 2.5 Hrs would not require to manually reboot it.

Copy link
Collaborator

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvantor yvantor changed the title [SECD] Bumping OpenTitan [SECD] Bump OpenTitan for reduced memory and iDMA. Mar 26, 2024
@yvantor yvantor merged commit a544bdd into astral Mar 26, 2024
13 checks passed
yvantor pushed a commit that referenced this pull request Apr 13, 2024
* Integrating 2nd master axi port for opentitan's IDMA

* Finalize OpenTitan's idma port in carfield. Now passing the test.

* Fixing linting errors.

* Fixing typo

* Bumping OT with fixes for CI and update CI with idma test.

* Fix minor unclear stuff.

* Fix last PR comments and typos.

* Fix linting errs

* Fix linting errs

* Removing useless parameters from structs

* Increasing to 3h the CI timeout

* Bump PULP cluster and other IPs.

---------

Co-authored-by: Maicol Ciani <[email protected]>
Co-authored-by: Yvan Tortorella <[email protected]>
@yvantor yvantor deleted the mc/ot-idma-bump-rebased branch May 5, 2024 12:07
VictorIsachi pushed a commit that referenced this pull request May 27, 2024
* Integrating 2nd master axi port for opentitan's IDMA

* Finalize OpenTitan's idma port in carfield. Now passing the test.

* Fixing linting errors.

* Fixing typo

* Bumping OT with fixes for CI and update CI with idma test.

* Fix minor unclear stuff.

* Fix last PR comments and typos.

* Fix linting errs

* Fix linting errs

* Removing useless parameters from structs

* Increasing to 3h the CI timeout

* Bump PULP cluster and other IPs.

---------

Co-authored-by: Maicol Ciani <[email protected]>
Co-authored-by: Yvan Tortorella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants