[kube-state-metrics] add option to add initContainers and additional sidecars #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrischdi
force-pushed
the
pr-ksm-init-and-add-containers
branch
from
fa111f3 to
24590a9
Compare
…sidecars Signed-off-by: Christian Schlotter <[email protected]>
chrischdi
force-pushed
the
pr-ksm-init-and-add-containers
branch
from
24590a9 to
1c8a866
Compare
dotdc
approved these changes
Oct 4, 2023
|
Thank you for your contribution @chrischdi ! |
This was referenced Oct 4, 2023
Matiasmct
pushed a commit
to giffgaff/prometheus-charts-backup
that referenced
this pull request
Mar 20, 2024
…sidecars (prometheus-community#3861) Signed-off-by: Christian Schlotter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds the option to add additional containers and initContainers to the kube-state-metrics helm chart.
This becomes handy when adding a sidecar to e.g. automatically update the crd configuration file.
Currently it requires patching the chart e.g. as done in: https://github.com/kubernetes-sigs/cluster-api/blob/main/hack/observability/kube-state-metrics/kustomization.yaml (post
helm template).Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])