Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] Support for adding sidecar container from values file #3479

Closed
iamshinto opened this issue Jun 9, 2023 · 2 comments
Closed
Labels
enhancement New feature or request lifecycle/stale

Comments

@iamshinto
Copy link

Is your feature request related to a problem ?

We are using KSM to monitor CRDs in our cluster and the metrics definition is defined as separate configmaps for each CRD. We would like to make use of a sidecar container which will be used to create a combined configmap of the metrics configuration and then supply this as the KSM configuration.

Describe the solution you'd like.

Update the deployment template to add fields for additional containers and volumes to be passed as an input from the helm values file

Describe alternatives you've considered.

We tried using the chart provided by bitnami which supports this feature but it does not support monitoring custom resources.

We tried patching the deployment from argocd in a local setup but in our existing setup this is deployed as part of a crossplane composition and can't patch the deployment there. Currently we are using kyverno to combine the configmaps and would like to replace it with this sidecar solution and make the configuration auto generated from a list of resource definitions.

Additional context.

No response

@iamshinto iamshinto added the enhancement New feature or request label Jun 9, 2023
@stale
Copy link

stale bot commented Aug 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@dotdc
Copy link
Member

dotdc commented Oct 4, 2023

Hi @iamshinto,
This should be fixed by #3861

@dotdc dotdc closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lifecycle/stale
Projects
None yet
Development

No branches or pull requests

2 participants