Rewrite dumper in Go #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
LGTM overall 🚀
The switch from files to command line flags for the must-exist and ignore resources configs will most likely require adjustments in https://github.com/projectsyn/component-cluster-backup
Differences: - All APIs are fully qualified in both the options (`--must-exist=certificates.cert-manager.io`, `--ignore=deployment.apps`) and the output files (`objects-Certificate.cert-manager.io.json`). This makes it possible to distinguish between objects with the same kind but different groups. See #47. - Resources without a list endpoint are ignored and do not cause and error or need to be explicitly ignored. - Ignore and must-exist options are now command line flags instead of files in `/usr/local/share`. Fixes #47 and #42.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences:
--must-exist=certificates.cert-manager.io,--ignore=deployment.apps) and the output files (objects-Certificate.cert-manager.io.json). This makes it possible to distinguish between objects with the same kind but different groups. See Dumper silently fails for ambiguous kinds with multiple groups #47./usr/local/share.Fixes #47 and maybe #42.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog