Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubectl get chunk size configurable #45

Closed
wants to merge 1 commit into from

Conversation

simu
Copy link
Member

@simu simu commented Aug 5, 2024

Also reduce chunk size to 100 (from 500) by default to reduce kubectl memory usage when dumping resource kinds with large individual resources.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Aug 5, 2024
Also reduce chunk size to 100 (from 500) by default to reduce `kubectl`
memory usage when dumping resource kinds with large individual
resources.
@simu simu force-pushed the feat/configurable-chunk-size branch from ad62e8b to d857fb5 Compare August 5, 2024 11:25
@simu simu requested a review from a team August 5, 2024 11:26
@simu
Copy link
Member Author

simu commented Aug 5, 2024

Update: after some more testing it looks like for high object counts (maybe > 5k or > 10k) neither --chunk-size=100 nor the default --chunk-size=500 return all objects when executing kubectl get -A <resource> with the corresponding chunk size flag. I haven't found any particularly relevant bug reports yet, and am still investigating.

@simu
Copy link
Member Author

simu commented Sep 20, 2024

Update: after some more testing it looks like for high object counts (maybe > 5k or > 10k) neither --chunk-size=100 nor the default --chunk-size=500 return all objects when executing kubectl get -A <resource> with the corresponding chunk size flag. I haven't found any particularly relevant bug reports yet, and am still investigating.

Follow-up: Looks like pagination is only broken for resources managed by the openshift-apiserver, not sure how/if we want to proceed here.

@bastjan
Copy link
Contributor

bastjan commented Nov 15, 2024

Implemented in #49

@bastjan bastjan closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants