Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to warn people to add config to vscode if need to compile fo… #6116

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Add note to warn people to add config to vscode if need to compile fo… #6116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b2836d
Add note to warn people to add config to vscode if need to compile fo…
lubronzhan Jan 22, 2024
5a5cdb2
Fix comment
lubronzhan Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,9 @@ In general, changes to the core processing pipeline should be accompanied by new
| `internal/featuretests/v3/*_test.go` | Tests conversion of Kubernetes config to Envoy config, using a ~full Contour event handler and xDS server. |
| `test/e2e/[httpproxy\|gateway\|ingress]` | E2E tests with Contour running in a cluster. Verifies behavior of HTTP requests for configured proxies. |

> **Note:**
To compile code under folder `e2e` with VSCode, please add `"go.buildTags": "e2e,conformance"` to VSCode config file `settings.json`. Since tests under it have e2e and conformance build tags.


## DCO Sign off

Expand Down