Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to warn people to add config to vscode if need to compile fo… #6116

Merged

Conversation

lubronzhan
Copy link
Contributor

…lder under e2e test

@lubronzhan lubronzhan requested a review from a team as a code owner January 22, 2024 08:04
@lubronzhan lubronzhan requested review from tsaarni and skriss and removed request for a team January 22, 2024 08:04
@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team January 22, 2024 08:04
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea4d4f9) 0.00% compared to head (5a5cdb2) 78.84%.
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #6116       +/-   ##
=========================================
+ Coverage      0   78.84%   +78.84%     
=========================================
  Files         0      138      +138     
  Lines         0    19730    +19730     
=========================================
+ Hits          0    15557    +15557     
- Misses        0     3870     +3870     
- Partials      0      303      +303     

see 138 files with indirect coverage changes

@tsaarni tsaarni added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jan 22, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Lubron Zhan <[email protected]>
@sunjayBhatia sunjayBhatia enabled auto-merge (squash) January 22, 2024 18:12
@sunjayBhatia sunjayBhatia merged commit 5c54c2b into projectcontour:main Jan 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants