Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove initial readiness probe delay #6099

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Remove initial readiness probe delay #6099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a418bc8
Remove initial readiness probe delay
sunjayBhatia Jan 19, 2024
bf24dd4
remove from provisioner generated deployment as well
sunjayBhatia Jan 19, 2024
f8e8534
changelog
sunjayBhatia Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelogs/unreleased/6099-sunjayBhatia-minor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Remove Contour container readiness probe initial delay

The Contour Deployment Contour server container previously had its readiness probe `initialDelaySeconds` field set to 15.
This has been removed from the example YAML manifests and Gateway Provisioner generated Contour Deployment since as of [PR #5672](https://github.com/projectcontour/contour/pull/5672) Contour's xDS server will not start or serve any configuration (and the readiness probe will not succeed) until the existing state of the cluster is synced.
In clusters with few resources this will improve the Contour Deployment's update/rollout time as initial startup time should be low.
1 change: 0 additions & 1 deletion examples/contour/03-contour.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ spec:
readinessProbe:
tcpSocket:
port: 8001
initialDelaySeconds: 15
periodSeconds: 10
volumeMounts:
- name: contourcert
Expand Down
1 change: 0 additions & 1 deletion examples/render/contour-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9053,7 +9053,6 @@ spec:
readinessProbe:
tcpSocket:
port: 8001
initialDelaySeconds: 15
periodSeconds: 10
volumeMounts:
- name: contourcert
Expand Down
1 change: 0 additions & 1 deletion examples/render/contour-gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9056,7 +9056,6 @@ spec:
readinessProbe:
tcpSocket:
port: 8001
initialDelaySeconds: 15
periodSeconds: 10
volumeMounts:
- name: contourcert
Expand Down
1 change: 0 additions & 1 deletion examples/render/contour.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9053,7 +9053,6 @@ spec:
readinessProbe:
tcpSocket:
port: 8001
initialDelaySeconds: 15
periodSeconds: 10
volumeMounts:
- name: contourcert
Expand Down
9 changes: 4 additions & 5 deletions internal/provisioner/objects/deployment/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,10 @@ func DesiredDeployment(contour *model.Contour, image string) *appsv1.Deployment
},
},
},
TimeoutSeconds: int32(1),
InitialDelaySeconds: int32(15),
PeriodSeconds: int32(10),
SuccessThreshold: int32(1),
FailureThreshold: int32(3),
TimeoutSeconds: int32(1),
PeriodSeconds: int32(10),
SuccessThreshold: int32(1),
FailureThreshold: int32(3),
},
TerminationMessagePath: "/dev/termination-log",
TerminationMessagePolicy: corev1.TerminationMessageReadFile,
Expand Down