Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial readiness probe delay #6099

Conversation

sunjayBhatia
Copy link
Member

Fixes: #5803

@sunjayBhatia sunjayBhatia added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Jan 19, 2024
@sunjayBhatia sunjayBhatia force-pushed the remove-contour-initial-readiness-delay branch from 568a401 to 5884e65 Compare January 19, 2024 16:20
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ae0bfa) 78.85% compared to head (f8e8534) 78.84%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6099      +/-   ##
==========================================
- Coverage   78.85%   78.84%   -0.01%     
==========================================
  Files         138      138              
  Lines       19731    19730       -1     
==========================================
- Hits        15558    15557       -1     
  Misses       3870     3870              
  Partials      303      303              
Files Coverage Δ
...ernal/provisioner/objects/deployment/deployment.go 88.98% <100.00%> (-0.05%) ⬇️

@skriss
Copy link
Member

skriss commented Jan 19, 2024

Should remove it from the provisioner-generated Deployment too, that'll make Gateway API conformance run much faster

@sunjayBhatia sunjayBhatia force-pushed the remove-contour-initial-readiness-delay branch from 2f8ca26 to dca9a22 Compare January 22, 2024 15:58
Signed-off-by: Sunjay Bhatia <[email protected]>
@sunjayBhatia sunjayBhatia force-pushed the remove-contour-initial-readiness-delay branch from dca9a22 to f8e8534 Compare January 22, 2024 15:59
@sunjayBhatia sunjayBhatia marked this pull request as ready for review January 22, 2024 15:59
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner January 22, 2024 15:59
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team, izturn and clayton-gonsalves and removed request for a team January 22, 2024 15:59
@sunjayBhatia sunjayBhatia merged commit 0fc3b5d into projectcontour:main Jan 22, 2024
27 checks passed
@sunjayBhatia sunjayBhatia deleted the remove-contour-initial-readiness-delay branch January 22, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lower the Contour deployment's readiness probe initial delay
2 participants