Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update proxy-proto.md to remove warning about aws load balancer annotations not working #6097

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Update proxy-proto.md to remove warning about aws load balancer annotations not working #6097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f43280
Update proxy-proto.md to remove warning about aws load balancer annot…
luong-komorebi Jan 17, 2024
4d37e71
remove excessive ref-link footnote
luong-komorebi Jan 17, 2024
fdecdca
migrate changes to the main folder for new versions
luong-komorebi Jan 17, 2024
15fcbff
Back port changes from main to 1.25, 1.26, 1.27
luong-komorebi Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions site/content/docs/1.25/guides/proxy-proto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The former cannot be used to load balance TLS traffic, because your cloud provid
So the latter must be used when Contour handles HTTP and HTTPS traffic.

However this leads to a situation where the remote IP address of the client is reported as the inside address of your cloud provider's load balancer.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.

## Enable PROXY protocol on your service in GKE

Expand All @@ -35,8 +35,6 @@ spec:
...
```

**NOTE**: The service annotation `service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'` used to toggle the PROXY protocol is found to have no effect on NLBs (Due to this open [issue][2]). Hence, follow the steps mentioned in this AWS [documentation][3] to manually toggle PROXY protocol on NLBs

## Enable PROXY protocol support for all Envoy listening ports

```
Expand All @@ -53,5 +51,3 @@ spec:

[0]: http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
[1]: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer
[2]: https://github.com/kubernetes/kubernetes/issues/57250
[3]: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#enable-proxy-protocol
6 changes: 1 addition & 5 deletions site/content/docs/1.26/guides/proxy-proto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The former cannot be used to load balance TLS traffic, because your cloud provid
So the latter must be used when Contour handles HTTP and HTTPS traffic.

However this leads to a situation where the remote IP address of the client is reported as the inside address of your cloud provider's load balancer.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.

## Enable PROXY protocol on your service in GKE

Expand All @@ -35,8 +35,6 @@ spec:
...
```

**NOTE**: The service annotation `service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'` used to toggle the PROXY protocol is found to have no effect on NLBs (Due to this open [issue][2]). Hence, follow the steps mentioned in this AWS [documentation][3] to manually toggle PROXY protocol on NLBs

## Enable PROXY protocol support for all Envoy listening ports

```
Expand All @@ -53,5 +51,3 @@ spec:

[0]: http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
[1]: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer
[2]: https://github.com/kubernetes/kubernetes/issues/57250
[3]: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#enable-proxy-protocol
6 changes: 1 addition & 5 deletions site/content/docs/1.27/guides/proxy-proto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ The former cannot be used to load balance TLS traffic, because your cloud provid
So the latter must be used when Contour handles HTTP and HTTPS traffic.

However this leads to a situation where the remote IP address of the client is reported as the inside address of your cloud provider's load balancer.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.
To rectify the situation, you can add annotations to your service and flags to your Contour Deployment or DaemonSet to enable the [PROXY][0] protocol which forwards the original client IP details to Envoy.

## Enable PROXY protocol on your service in GKE

Expand All @@ -35,8 +35,6 @@ spec:
...
```

**NOTE**: The service annotation `service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'` used to toggle the PROXY protocol is found to have no effect on NLBs (Due to this open [issue][2]). Hence, follow the steps mentioned in this AWS [documentation][3] to manually toggle PROXY protocol on NLBs

## Enable PROXY protocol support for all Envoy listening ports

```
Expand All @@ -53,5 +51,3 @@ spec:

[0]: http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
[1]: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer
[2]: https://github.com/kubernetes/kubernetes/issues/57250
[3]: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#enable-proxy-protocol
6 changes: 1 addition & 5 deletions site/content/docs/main/guides/proxy-proto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ spec:
...
```

**NOTE**: The service annotation `service.beta.kubernetes.io/aws-load-balancer-proxy-protocol: '*'` used to toggle the PROXY protocol is found to have no effect on NLBs (Due to this open [issue][2]). Hence, follow the steps mentioned in this AWS [documentation][3] to manually toggle PROXY protocol on NLBs

## Enable PROXY protocol support for all Envoy listening ports

```
Expand All @@ -52,6 +50,4 @@ spec:
```

[0]: http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt
[1]: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer
[2]: https://github.com/kubernetes/kubernetes/issues/57250
[3]: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#enable-proxy-protocol
[1]: https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer
Loading