Update proxy-proto.md to remove warning about aws load balancer annotations not working #6097
Conversation
…ations issue kubernetes/kubernetes#57250 has been resolved 2 years ago Signed-off-by: Luong Vo <[email protected]>
Signed-off-by: Luong Vo <[email protected]>
luong-komorebi
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
davinci26 and
clayton-gonsalves
and removed request for
a team
|
Hi @luong-komorebi! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6097 +/- ##
=======================================
Coverage 78.85% 78.85%
=======================================
Files 138 138
Lines 19731 19731
=======================================
Hits 15558 15558
Misses 3870 3870
Partials 303 303 |
There was a problem hiding this comment.
Thanks for the PR!
let's make this change in the main section of the docs (site/content/docs/main) so that new versions get this change and maybe a couple of the latest supported versions (currently 1.27-1.25, but if you wanted to go back a bit further to when this was fixed, feel free)
Signed-off-by: Luong Vo <[email protected]>
|
@sunjayBhatia thank you so much for the guidance. It did take me some time to realize I have been digging version 1.24 doc so carefully I missed out on later versions haha |
skriss
added
the
release-note/none-required
There was a problem hiding this comment.
Thanks for correcting this @luong-komorebi! Per @sunjayBhatia's previous comment, could you also make this same change to the following files which correspond to all supported Contour versions:
Signed-off-by: Luong Vo <[email protected]>
|
@skriss thank you. I have just changed the docs as you hinted. I am new to this project but willing to dedicate time for perfection so let me know if there are any other feedbacks I should address |
issue kubernetes/kubernetes#57250 has been resolved 2 years ago