Commits on Sep 7, 2022

1. devicemodel: hw: pci: gvt: Fix out of bounds error …

   hw/pci/gvt.c:263:41: error: array subscript 257 is above array bounds of ‘uint8_t[256]’ {aka ‘unsigned char[256]’} [-Werror=array-bounds]
     263 |                         gvt->host_config[cap_ptr + 4]);
         |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
   hw/pci/gvt.c:48:17: note: while referencing ‘host_config’
      48 |         uint8_t host_config[PCI_REGMAX+1];
         |                 ^~~~~~~~~~~
   
   With the additional condition cap_ptr < PCI_REGMAX - 16 it is ensured
   that we never read config data from places we shouldn't read from.
   
   12 (offset) + 4 (pci_set_cfgdata32) = 16
   
   I would consider this a workaround that gets the job done for
   now. However with this approach we can miss the last capabilities in
   some edge cases.
   
   Tracked-On: projectacrn#8116
   
   Signed-off-by: Marius Rodi <[email protected]>

   

   mariusrodi committed Sep 7, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 2f595f0
   • Browse repository at this point

   Copy the full SHA

   2f595f0 View commit details

   Browse the repository at this point in the history