Feature/feature map attribute and device type conformance/zapp 1346 #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding CHIP repo PR: project-chip/connectedhomeip#32930 |
brdandu
force-pushed
the
feature/featureMapAttributeAndDeviceTypeConformance/ZAPP-1346
branch
2 times, most recently
from
5d174ab to
ec701ac
Compare
paulr34
approved these changes
Apr 11, 2024
brdandu
force-pushed
the
feature/featureMapAttributeAndDeviceTypeConformance/ZAPP-1346
branch
from
cb99976 to
7fa6886
Compare
…pe features per endpoint - Creating the feature table and populating it with data from the xml - Creating the data_type_feature table which references to data type cluster and feature ids. Populating it the same way as the data type attributes and data type commands. For now only adding those features which are of mandatory conformance for now. - Adding selectDeviceTypeFeaturesByEndpointTypeIdAndClusterId to extract the features per endpoint type and cluster for setting the featureMap attribute appropriately. - Using the above function from query-config#insertOrUpdateAttributeState to update the featureMap attribute accordingly when its value is 0. - Start reporting featureMap attribute value warnings for each endpoint based on device type conformance - Adding unit tests for the device type cluster compliance for feature map attribute - Adding features in cluster xml as a bitmap such that bitmap name='feature' can be removed from the xml in favor of features which holds the featuremap information as well as defines the feature bitmap such that there is no duplicate information between features and bitmap name=feature - Showing the correct UI based on category from json files when there is only one zcl and template package and user does not have any packages to select from. - Making sure the same named feature codes which exist on different bits of the cluster are handled correctly - Updating the zap schema as per the new changes - JIRA: ZAPP-1346
brdandu
force-pushed
the
feature/featureMapAttributeAndDeviceTypeConformance/ZAPP-1346
branch
from
3e60df7 to
2498871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature provides automatic setting of feature map attribute based on mandatory features from the device type conformance. The changes should also warn existing app users with warnings during .zap file open