Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the existing xml with features per cluster and features per device type #32930

Conversation

brdandu
Copy link
Contributor

@brdandu brdandu commented Apr 10, 2024

JIRA: ZAPP-1346

No direct chip repo ticket associated to the changes here. However, these changes are associated to populating the feature map attribute based on the device type selected in ZAP. See ZAP PR: project-chip/zap#1300 .

Note: The ZAP changes here only populate the feature map attribute for mandatory features for now during the creation of an endpoint. Existing apps will also get a warning during the .zap file open if the feature map attribute is not correctly set as per the device type specification for features.

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no codegen changes from this change. Any codegen changes are bugs in either ZAP or the new XML bits.

@brdandu
Copy link
Contributor Author

brdandu commented Apr 16, 2024

There should be no codegen changes from this change. Any codegen changes are bugs in either ZAP or the new XML bits.

I have updated the xml the best I could. The remaining diffs seem to be issues with the old xml bitmap features which do not exist in the new xml.

JIRA: ZAPP-1346
@brdandu
Copy link
Contributor Author

brdandu commented Apr 16, 2024

There should be no codegen changes from this change. Any codegen changes are bugs in either ZAP or the new XML bits.

Code gen changes are caused by the new xml since it does not match bitmap feature which existed in the xml. I do not see any zap issues here. If the new xml is the source of truth for features/bitmap feature then we should merge this PR.

Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; this is much better!

Please do make sure there is a followup tracking the duplicated bits for the alias clusters....

@brdandu
Copy link
Contributor Author

brdandu commented Apr 17, 2024

Thank you; this is much better!

Please do make sure there is a followup tracking the duplicated bits for the alias clusters....

Np. Will follow up on the duplicate features across clusters

@mergify mergify bot merged commit 4322a88 into project-chip:master Apr 18, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants