-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the existing xml with features per cluster and features per device type #32930
Updating the existing xml with features per cluster and features per device type #32930
Conversation
…device type JIRA: ZAPP-1346
…o populate the bitmap JIRA: ZAPP-1346
JIRA: ZAPP-1346
JIRA: ZAPP-1346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no codegen changes from this change. Any codegen changes are bugs in either ZAP or the new XML bits.
JIRA: ZAPP-1346
src/app/zap-templates/zcl/data-model/chip/network-commissioning-cluster.xml
Show resolved
Hide resolved
I have updated the xml the best I could. The remaining diffs seem to be issues with the old xml bitmap features which do not exist in the new xml. |
src/app/zap-templates/zcl/data-model/chip/color-control-cluster.xml
Outdated
Show resolved
Hide resolved
JIRA: ZAPP-1346
Code gen changes are caused by the new xml since it does not match bitmap feature which existed in the xml. I do not see any zap issues here. If the new xml is the source of truth for features/bitmap feature then we should merge this PR. |
JIRA: ZAPP-1346
JIRA: ZAPP-1346
JIRA: ZAPP-1346
JIRA: ZAPP-1346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you; this is much better!
Please do make sure there is a followup tracking the duplicated bits for the alias clusters....
Np. Will follow up on the duplicate features across clusters |
JIRA: ZAPP-1346
No direct chip repo ticket associated to the changes here. However, these changes are associated to populating the feature map attribute based on the device type selected in ZAP. See ZAP PR: project-chip/zap#1300 .
Note: The ZAP changes here only populate the feature map attribute for mandatory features for now during the creation of an endpoint. Existing apps will also get a warning during the .zap file open if the feature map attribute is not correctly set as per the device type specification for features.