Decouple PumpConfigurationAndControl from EmberCompat #36045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the ember internal function instead of the ember compatibility functions override. It is somewhat unclear why we have an override that replaces one method with a single method that is identical except arguments.
|
Review changes with SemanticDiff. |
|
PR #36045: Size comparison from a712f77 to a998701 Full report (9 builds for cc32xx, nxp, stm32)
|
andy31415
force-pushed
the
ember_decouple_pump
branch
from
00255f9 to
a998701
Compare
|
PR #36045: Size comparison from 7287041 to a998701 Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Oct 15, 2024
|
fast tracking after 5 days. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…6045) This uses the ember internal function instead of the ember compatibility functions override. It is somewhat unclear why we have an override that replaces one method with a single method that is identical except arguments. Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the ember internal function instead of the ember compatibility functions override. It is somewhat unclear why we have an override that replaces one method with a single method that is identical except arguments.
clusters implementations are often coupled to ember, however they should not be coupled to ember-compatibility-functions.cpp
We should also figure out if there is some other way updating things as relying that we have a "ember default" is somewhat odd here.