[Feature] Adding Step Endpoint Information #35662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 5 of 5 files. Overall, the semantic diff is 15% smaller than the GitHub diff.
|
github-actions
bot
added
scripts
tests
matter-1.4-te2-script-change
|
PR #35662: Size comparison from 0d17a40 to 9be444b Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #35662: Size comparison from 0d17a40 to 9be67e1 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
antonio-amjr
changed the title
antonio-amjr
force-pushed
the
feature/device_endpoint_ui_presentation
branch
2 times, most recently
from
7afb143 to
3b00bf5
Compare
|
PR #35662: Size comparison from 12f04dc to 3b00bf5 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
antonio-amjr
force-pushed
the
feature/device_endpoint_ui_presentation
branch
from
3b00bf5 to
ec803c5
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91 and
fessehaeve
pullapprove
bot
requested review from
tecimovic,
tehampson,
tima-q,
tobiasgraf,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35662: Size comparison from 4bdafa2 to ec803c5 Full report (82 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…h logging. Also, the TC_ACE_1_3 and TC_BOOLCFG_2_1 tests were updated to demonstrate how to used the updated hooks to inform the endpoint associated with every step.
Co-authored-by: Boris Zbarsky <[email protected]>
antonio-amjr
force-pushed
the
feature/device_endpoint_ui_presentation
branch
from
e7ff05b to
0b0368c
Compare
|
PR #35662: Size comparison from 237e450 to 0b0368c Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Sep 26, 2024
cecille
added a commit
to cecille/connectedhomeip
that referenced
this pull request
Oct 22, 2024
This reverts commit 36fff94. This breaks the TH and the API for the step command is overkill.
cecille
added a commit
to cecille/connectedhomeip
that referenced
this pull request
Oct 22, 2024
This reverts commit 36fff94. This breaks the TH and the API for the step command is overkill.
andy31415
pushed a commit
that referenced
this pull request
Oct 22, 2024
andy31415
pushed a commit
that referenced
this pull request
Oct 22, 2024
|
@cecille This PR entered by mistake in the v1.4 but it was meant to enter only in the v1.5 in sync with the Backend's PR project-chip/certification-tool-backend#147 to handle the feature request project-chip/certification-tool#367. Since I noticed the change was reverted for both master and v1.4, let me know if it's ok to create this PR again for this feature request or if it's necessary to try a different solution. |
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
* Adding endpoint information to test steps methods and hooks along with logging. Also, the TC_ACE_1_3 and TC_BOOLCFG_2_1 tests were updated to demonstrate how to used the updated hooks to inform the endpoint associated with every step. * Rolling back the test stop unnecessary exception parameter * Updating TestDecoratorHooks with endpoint as well. * Minor grammar fix Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
yyzhong-g
pushed a commit
to yyzhong-g/connectedhomeip
that referenced
this pull request
Dec 12, 2024
…" (project-chip#36198) This reverts commit 36fff94. This breaks the TH and the API for the step command is overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: project-chip/certification-tool#367
Backend Dependency PR: project-chip/certification-tool-backend#147
Warning
The frontend changes and images shown here are not official and for experimental purpose only.
Description
Updating the Step Start hooks and the related code to include an optional endpoint information. Also, some logging were updated to show the endpoint if it exists.
This change depends on the backend's PR, mentioned above, that receives the new endpoint data and redirect it to the frontend via test UI observables so it may access and show as desired.
Please, mind this current solution will not store the endpoint information in the DB and it will not be retrieved for the UI after loading old executions. Anyway, the logs still points the endpoint on the step completion lines.
The
TC_ACE_1_3andTC_BOOLCFG_2_1tests were updated to demonstrate how to send the endpoint through the backend hooks. | update to demonstrate how to used the updated hooks to inform the endpoint associated with every step.Use Case Example:
Warning
The frontend changes and images shown here are not official and for experimental purpose only.
The images below show a possible usage of the new endpoint information passed to the frontend using the SDK and Backend changes:
The TC ACE 1.3 example
The TC BOOLCFG 2.1 example