[Feature] Updating Step Start Hook to Receive Endpoint #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonio-amjr
changed the title
antonio-amjr
requested review from
ccruzagralopes,
hiltonlima,
rquidute,
fabiowmm and
gladystonfranca
and removed request for
hiltonlima
ccruzagralopes
approved these changes
Sep 26, 2024
|
@antonio-amjr could you rebase/target to |
antonio-amjr
changed the base branch from
v2.11-beta3.1+fall2024
to
spring2025
antonio-amjr
force-pushed
the
feature/device_endpoint_ui_presentation
branch
from
859dd3f to
685f73f
Compare
Done @hiltonlima |
hiltonlima
approved these changes
Oct 23, 2024
hiltonlima
force-pushed
the
spring2025
branch
from
ad73477 to
0bb4f89
Compare
All the related code were updated along with the necessary logging. Also, the UI observable were updated to signalize the frontend websocket with the endpoint information for every step.
antonio-amjr
force-pushed
the
feature/device_endpoint_ui_presentation
branch
from
685f73f to
f52a2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: project-chip/certification-tool#367
SDK Dependency PR:
project-chip/connectedhomeip#35662(The SDK PR entered out of sync with this backend PR causing problems TH. The change was then reverted on the SDK's side and a new PR should be created to pair with this one)Warning
The frontend changes and images shown here are not official and for experimental purpose only.
Also, the SDK dependency PR should merge in sync with this PR
Description
Updating the Step Start hooks and the related code to use the provided optional endpoint information from SDK. Also, logs were updated to show the endpoint, if it exists.
This change depends on the SDK's PR, mentioned above, that sends the endpoint information by including it on TC Step Start method parameters.
Please, mind this current solution will not store the endpoint information in the DB and it will not be retrieved for the UI after loading old executions. Anyway, the logs still points the endpoint on the step completion lines.
Use Case Example:
Warning
The frontend changes and images shown here are not official and for experimental purpose only.
Also, the SDK dependency PR should merge in sync with this PR
The images below show a possible usage of the new endpoint information passed to the frontend using the SDK and Backend changes:
The TC ACE 1.3 example
The TC BOOLCFG 2.1 example