-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Add Check-In message check when switching to idle mode #31563
Merged
mergify
merged 14 commits into
project-chip:master
from
mkardous-silabs:fix/operational_switch
Jan 30, 2024
Merged
[ICD] Add Check-In message check when switching to idle mode #31563
mergify
merged 14 commits into
project-chip:master
from
mkardous-silabs:fix/operational_switch
Jan 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #31563: Size comparison from ddc961d to d478a47 Increases (14 builds for efr32, k32w, qpg, telink)
Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
previously approved these changes
Jan 19, 2024
yunhanw-google
previously approved these changes
Jan 19, 2024
mkardous-silabs
force-pushed
the
fix/operational_switch
branch
from
January 19, 2024 23:10
de37e35
to
6721436
Compare
PR #31563: Size comparison from e553129 to 6721436 Increases (14 builds for efr32, k32w, qpg, telink)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
mkardous-silabs
force-pushed
the
fix/operational_switch
branch
from
January 22, 2024 14:57
30dd12e
to
b91c50f
Compare
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
January 22, 2024 14:57
PR #31563: Size comparison from 30a7636 to f48be4c Increases (3 builds for cc32xx, stm32)
Full report (3 builds for cc32xx, stm32)
|
mkardous-silabs
force-pushed
the
fix/operational_switch
branch
from
January 30, 2024 20:29
f48be4c
to
493218f
Compare
PR #31563: Size comparison from f25b0b8 to 493218f Increases (4 builds for cc32xx, mbed, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
jmartinez-silabs
approved these changes
Jan 30, 2024
PR #31563: Size comparison from f25b0b8 to c2bf5f8 Increases (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (2 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
This was referenced Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where ICD was not sending at least 1 Check-In message every 1 IdleModeInterval.
PR adds a check when we determine if we need to start an IdleModeInterval timer.
Start timer if :
Issue was introduced when the optimization for the ActiveModeInterval = 0 scenario was merged; Issue only happens if ActiveModeInterval = 0.
If the ActiveModeInterval is equal to 0, we do not start an timer for the IdleModeInterval since we would immediatly return to IdleMode if we have nothing to do.
Since we didn't check if we would need to send Check-In message,s ICD would remain in IdleMode and not send a Check-In message every IdleModeInterval.
Tests didn't catch the regression because of the merge timing between Check-In support, the ActiveModeInterval optimization and the fact that the unit test do use ActiveModeInterval = 0.
PR also adds a new interface implemented by the InteractionModelEngine since depending on the InteractionModelEngine in the ICDManager forces the inclusion of global data model function that are not implemented in the unit test run.
TODO in follow up :
By Product :
Tests
Add unit tests to validate OprationalState changes when ActiveModeInterval = 0
Manual tests were also done to validate the behavior