Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GroupedWindowAggStream #21

Merged
merged 9 commits into from
Aug 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ chrono = { version = "0.4.38", default-features = false }
itertools = "0.13"

[patch.crates-io]
datafusion = { git = "https://github.com/probably-nothing-labs/arrow-datafusion" }
datafusion = { git = "https://github.com/probably-nothing-labs/arrow-datafusion", rev="fc67038" }
2 changes: 1 addition & 1 deletion clippy.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ disallowed-types = [
# Lowering the threshold to help prevent stack overflows (default is 16384)
# See: https://rust-lang.github.io/rust-clippy/master/index.html#/large_futures
future-size-threshold = 10000
too-many-arguments-threshold = 10
too-many-arguments-threshold = 15
2 changes: 2 additions & 0 deletions crates/core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ rocksdb = "0.22.0"
bincode = "1.3.3"
half = "2.4.1"
delegate = "0.12.0"
ahash = "0.8.11"
hashbrown = "0.14.5"
13 changes: 5 additions & 8 deletions crates/core/src/datastream.rs
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,11 @@ impl DataStream {
loop {
match stream.next().await.transpose() {
Ok(Some(batch)) => {
for i in 0..batch.num_rows() {
let row = batch.slice(i, 1);
println!(
"{}",
datafusion::common::arrow::util::pretty::pretty_format_batches(&[row])
.unwrap()
);
}
println!(
"{}",
datafusion::common::arrow::util::pretty::pretty_format_batches(&[batch])
.unwrap()
);
}
Ok(None) => {
log::warn!("No RecordBatch in stream");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use datafusion::physical_plan::ExecutionPlanProperties;
use datafusion::common::tree_node::{Transformed, TransformedResult, TreeNode};
use datafusion::error::Result;

use crate::physical_plan::streaming_window::FranzStreamingWindowExec;
use crate::physical_plan::continuous::streaming_window::FranzStreamingWindowExec;

pub struct CoaslesceBeforeStreamingAggregate {}

Expand Down
Loading