Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding GroupedWindowAggStream #21

Merged
merged 9 commits into from
Aug 15, 2024
Merged

Adding GroupedWindowAggStream #21

merged 9 commits into from
Aug 15, 2024

Conversation

ameyc
Copy link
Contributor

@ameyc ameyc commented Aug 15, 2024

This PR -

  1. Enabled Group Bys in Streaming Windows.

@ameyc ameyc requested a review from emgeee August 15, 2024 00:44
emgeee
emgeee approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@emgeee emgeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated our datafusion fork to make certain elements public so we don't have to duplicate code here. I also fixed formatting so this PR is ready to merge

@ameyc ameyc merged commit d9d3142 into main Aug 15, 2024
2 checks passed
@ameyc ameyc deleted the amey/grouping-aggregates branch August 15, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emgeee emgeee emgeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameyc @emgeee