Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insertMany function in LeanIMT #104

Merged
merged 12 commits into from
Jan 3, 2024
Merged

Add insertMany function in LeanIMT #104

merged 12 commits into from
Jan 3, 2024

Conversation

vplasencia
Copy link
Member

Related Issue

Closes #81

Does this introduce a breaking change?

  • Yes
  • No

@vplasencia vplasencia marked this pull request as draft December 13, 2023 11:50
@vplasencia vplasencia marked this pull request as ready for review December 13, 2023 23:16
@vplasencia vplasencia requested review from cedoor and 0xjei December 13, 2023 23:16
@vplasencia vplasencia requested a review from cedoor December 18, 2023 12:24
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few typos, the rest looks great to me!

Great job 🔥

packages/imt.sol/contracts/internal/InternalLeanIMT.sol Outdated Show resolved Hide resolved
packages/imt.sol/contracts/internal/InternalLeanIMT.sol Outdated Show resolved Hide resolved
Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Few nits on comments and naming but overall looks good. Thanks @vplasencia for your time and effort!

@cedoor cedoor merged commit 9dbe3e7 into main Jan 3, 2024
2 checks passed
@cedoor cedoor deleted the feat/insert-many-leanimt branch January 3, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a function to add many leaves to the LeanIMT.sol tree
3 participants