-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to update many members at once to the LeanIMT implementation #117
Labels
feature 🚀
This is enhancing something existing or creating something new
good first issue
Good for newcomers
Comments
cedoor
added
the
feature 🚀
This is enhancing something existing or creating something new
label
Jan 8, 2024
Hi! I'd like to take this issue. :) |
Hey @ChinoCribioli! I just assigned the issue to you. Thanks. Feel free to ask any questions you may have. |
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 28, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 28, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 29, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 29, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 31, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Aug 31, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 1, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 1, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 1, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 1, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 2, 2024
ChinoCribioli
added a commit
to ChinoCribioli/zk-kit
that referenced
this issue
Sep 2, 2024
7 tasks
vplasencia
added a commit
that referenced
this issue
Sep 9, 2024
* feat(lean-imt): added `updateMany` method to package re #117 * feat(lean-imt): implemented some tests on lean-imt re #117 * feat(lean-imt): added more precondition checks re #117 * feat(lean-imt): finished testing on `updateMany` method re #117 * feat(lean-imt): added test to the case when passing repeated indices re #117 * feat(lean-imt): added complexity documentation for `updateMany` method re #117 * feat(lean-imt): added test of several updates re #117 * feat(lean-imt): added repeated indices check re #117 * feat(lean-imt): changed error message to be more accurate re #117 * feat(lean-imt): added complexity in terms only of n re #117 * feat(lean-imt): changed documentation to add discussion in another issue re #117 * feat(lean-imt): fixed typo on documentation re #117 * Update packages/lean-imt/src/lean-imt.ts Co-authored-by: Vivian Plasencia <[email protected]> --------- Co-authored-by: Vivian Plasencia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature 🚀
This is enhancing something existing or creating something new
good first issue
Good for newcomers
Is your feature request related to a problem? Please describe.
The idea is to create a function called
updateMany
. This function can be useful to update many members at once. It should be more efficient to update N members usingupdateMany
once than using theupdate
function N times.Describe the solution you'd like
It would be nice to have an implementation for TypeScript and Solidity similar to the
insertMany
function (links below). Something to remember is that the TypeScript implementation will be different from the Solidity implementation, as the data saved and optimizations in both environments are different.Additional context
insertMany
TypeScript implementation: https://github.com/privacy-scaling-explorations/zk-kit/blob/main/packages/lean-imt/src/lean-imt.ts#L162insertMany
Solidity implementation: https://github.com/privacy-scaling-explorations/zk-kit.solidity/blob/main/packages/lean-imt/contracts/InternalLeanIMT.sol#L91The text was updated successfully, but these errors were encountered: