Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to update many members at once to the LeanIMT implementation #117

Closed
cedoor opened this issue Jan 8, 2024 · 4 comments · Fixed by #314
Closed

Add a function to update many members at once to the LeanIMT implementation #117

cedoor opened this issue Jan 8, 2024 · 4 comments · Fixed by #314
Assignees
Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers

Comments

@cedoor
Copy link
Member

cedoor commented Jan 8, 2024

Is your feature request related to a problem? Please describe.

The idea is to create a function called updateMany. This function can be useful to update many members at once. It should be more efficient to update N members using updateMany once than using the update function N times.

Describe the solution you'd like

It would be nice to have an implementation for TypeScript and Solidity similar to the insertMany function (links below). Something to remember is that the TypeScript implementation will be different from the Solidity implementation, as the data saved and optimizations in both environments are different.

Additional context

@cedoor cedoor added this to ZK-Kit Jan 8, 2024
@cedoor cedoor converted this from a draft issue Jan 8, 2024
@cedoor cedoor added the feature 🚀 This is enhancing something existing or creating something new label Jan 8, 2024
@cedoor cedoor moved this from 📋 Backlog to ♻️ Grooming in ZK-Kit Jan 8, 2024
@0xjei
Copy link
Member

0xjei commented Jan 16, 2024

@cedoor Should we mark this as completed? See #104

@cedoor
Copy link
Member Author

cedoor commented Jan 16, 2024

@cedoor Should we mark this as completed? See #104

This is another task. That's the insertMany function. This would be the updateMany.

@vplasencia vplasencia added the good first issue Good for newcomers label Apr 30, 2024
@ChinoCribioli
Copy link
Contributor

Hi! I'd like to take this issue. :)

@vplasencia
Copy link
Member

Hey @ChinoCribioli! I just assigned the issue to you. Thanks. Feel free to ask any questions you may have.

ChinoCribioli added a commit to ChinoCribioli/zk-kit that referenced this issue Aug 29, 2024
ChinoCribioli added a commit to ChinoCribioli/zk-kit that referenced this issue Sep 1, 2024
ChinoCribioli added a commit to ChinoCribioli/zk-kit that referenced this issue Sep 1, 2024
ChinoCribioli added a commit to ChinoCribioli/zk-kit that referenced this issue Sep 2, 2024
@cedoor cedoor moved this from ♻️ Grooming to 👀 In Review in ZK-Kit Sep 4, 2024
vplasencia added a commit that referenced this issue Sep 9, 2024
* feat(lean-imt): added `updateMany` method to package

re #117

* feat(lean-imt): implemented some tests on lean-imt

re #117

* feat(lean-imt): added more precondition checks

re #117

* feat(lean-imt): finished testing on `updateMany` method

re #117

* feat(lean-imt): added test to the case when passing repeated indices

re #117

* feat(lean-imt): added complexity documentation for `updateMany` method

re #117

* feat(lean-imt): added test of several updates

re #117

* feat(lean-imt): added repeated indices check

re #117

* feat(lean-imt): changed error message to be more accurate

re #117

* feat(lean-imt): added complexity in terms only of n

re #117

* feat(lean-imt): changed documentation to add discussion in another issue

re #117

* feat(lean-imt): fixed typo on documentation

re #117

* Update packages/lean-imt/src/lean-imt.ts

Co-authored-by: Vivian Plasencia <[email protected]>

---------

Co-authored-by: Vivian Plasencia <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✔️ Done in ZK-Kit Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 This is enhancing something existing or creating something new good first issue Good for newcomers
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

4 participants