Complete porting for MACI gatekeepers #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…horeExcubia deploy
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
0xjei
force-pushed
the
feat/porting-maci-gatekeepers
branch
from
771ec0b to
23f080e
Compare
these should just be inline-assembly (verifier) and naming (which is a false positive). |
ctrlc03
reviewed
Jul 10, 2024
ctrlc03
reviewed
Jul 10, 2024
ctrlc03
reviewed
Jul 10, 2024
ctrlc03
reviewed
Jul 10, 2024
packages/excubiae/contracts/extensions/ZKEdDSAEventTicketPCDExcubia.sol
Outdated
Show resolved
Hide resolved
ctrlc03
reviewed
Jul 10, 2024
packages/excubiae/contracts/extensions/ZKEdDSAEventTicketPCDExcubia.sol
Outdated
Show resolved
Hide resolved
cedoor
approved these changes
Jul 10, 2024
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2024
<!-- Please refer to our CONTRIBUTING documentation for any questions on submitting a pull request. --> <!-- Provide a general summary of your changes in the Title above. --> ## Description This PR adds the `GitcoinPassportExcubia`, `ZKEdDSAEventTicketPCDExcubia` (prev Zupass) and, `HatsExcubia`. During the porting process, certain interfaces were extended and controls and methods generalised. The code coverage is 100%. Also, this PR introduces the concept of `trait` aka the specific type of an Excubia contract. For example, `SemaphoreExcubia` has trait `Semaphore` and so on. This will make easy to discriminate and query multiple Excubiae sharing the same characteristics. <!-- Describe your changes in detail. --> <!-- You may want to answer some of the following questions: --> <!-- What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) --> <!-- What is the current behavior?** (You can also link to an open issue here) --> <!-- What is the new behavior (if this is a feature change)? --> <!-- Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) --> ## Related Issue(s) closes #18 <!-- This project accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- Please link to the issue(s) here --> <!-- Closes # --> <!-- Fixes # --> ## Checklist <!-- Please check if the PR fulfills these requirements. --> - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I have run `yarn format` and `yarn compile` without getting any errors - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2024
<!-- Please refer to our CONTRIBUTING documentation for any questions on submitting a pull request. --> <!-- Provide a general summary of your changes in the Title above. --> ## Description This PR adds the `GitcoinPassportExcubia`, `ZKEdDSAEventTicketPCDExcubia` (prev Zupass) and, `HatsExcubia`. During the porting process, certain interfaces were extended and controls and methods generalised. The code coverage is 100%. Also, this PR introduces the concept of `trait` aka the specific type of an Excubia contract. For example, `SemaphoreExcubia` has trait `Semaphore` and so on. This will make easy to discriminate and query multiple Excubiae sharing the same characteristics. <!-- Describe your changes in detail. --> <!-- You may want to answer some of the following questions: --> <!-- What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) --> <!-- What is the current behavior?** (You can also link to an open issue here) --> <!-- What is the new behavior (if this is a feature change)? --> <!-- Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) --> ## Related Issue(s) closes #18 <!-- This project accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- Please link to the issue(s) here --> <!-- Closes # --> <!-- Fixes # --> ## Checklist <!-- Please check if the PR fulfills these requirements. --> - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I have run `yarn format` and `yarn compile` without getting any errors - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2024
<!-- Please refer to our CONTRIBUTING documentation for any questions on submitting a pull request. --> <!-- Provide a general summary of your changes in the Title above. --> ## Description This PR adds the `GitcoinPassportExcubia`, `ZKEdDSAEventTicketPCDExcubia` (prev Zupass) and, `HatsExcubia`. During the porting process, certain interfaces were extended and controls and methods generalised. The code coverage is 100%. Also, this PR introduces the concept of `trait` aka the specific type of an Excubia contract. For example, `SemaphoreExcubia` has trait `Semaphore` and so on. This will make easy to discriminate and query multiple Excubiae sharing the same characteristics. <!-- Describe your changes in detail. --> <!-- You may want to answer some of the following questions: --> <!-- What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) --> <!-- What is the current behavior?** (You can also link to an open issue here) --> <!-- What is the new behavior (if this is a feature change)? --> <!-- Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) --> ## Related Issue(s) closes #18 <!-- This project accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- Please link to the issue(s) here --> <!-- Closes # --> <!-- Fixes # --> ## Checklist <!-- Please check if the PR fulfills these requirements. --> - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I have run `yarn format` and `yarn compile` without getting any errors - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2024
<!-- Please refer to our CONTRIBUTING documentation for any questions on submitting a pull request. --> <!-- Provide a general summary of your changes in the Title above. --> ## Description This PR adds the `GitcoinPassportExcubia`, `ZKEdDSAEventTicketPCDExcubia` (prev Zupass) and, `HatsExcubia`. During the porting process, certain interfaces were extended and controls and methods generalised. The code coverage is 100%. Also, this PR introduces the concept of `trait` aka the specific type of an Excubia contract. For example, `SemaphoreExcubia` has trait `Semaphore` and so on. This will make easy to discriminate and query multiple Excubiae sharing the same characteristics. <!-- Describe your changes in detail. --> <!-- You may want to answer some of the following questions: --> <!-- What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) --> <!-- What is the current behavior?** (You can also link to an open issue here) --> <!-- What is the new behavior (if this is a feature change)? --> <!-- Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?) --> ## Related Issue(s) closes #18 <!-- This project accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- Please link to the issue(s) here --> <!-- Closes # --> <!-- Fixes # --> ## Checklist <!-- Please check if the PR fulfills these requirements. --> - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented my code, particularly in hard-to-understand areas - [x] My changes generate no new warnings - [x] I have run `yarn format` and `yarn compile` without getting any errors - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
GitcoinPassportExcubia,ZKEdDSAEventTicketPCDExcubia(prev Zupass) and,HatsExcubia. During the porting process, certain interfaces were extended and controls and methods generalised. The code coverage is 100%.Also, this PR introduces the concept of
traitaka the specific type of an Excubia contract. For example,SemaphoreExcubiahas traitSemaphoreand so on. This will make easy to discriminate and query multiple Excubiae sharing the same characteristics.Related Issue(s)
closes #18
Checklist
yarn formatandyarn compilewithout getting any errors