Skip to content

Commit

Permalink
Complete porting for MACI gatekeepers (#31)
Browse files Browse the repository at this point in the history
<!-- Please refer to our CONTRIBUTING documentation for any questions on
submitting a pull request. -->
<!-- Provide a general summary of your changes in the Title above. -->

## Description
This PR adds the `GitcoinPassportExcubia`,
`ZKEdDSAEventTicketPCDExcubia` (prev Zupass) and, `HatsExcubia`. During
the porting process, certain interfaces were extended and controls and
methods generalised. The code coverage is 100%.

Also, this PR introduces the concept of `trait` aka the specific type of
an Excubia contract. For example, `SemaphoreExcubia` has trait
`Semaphore` and so on. This will make easy to discriminate and query
multiple Excubiae sharing the same characteristics.

<!-- Describe your changes in detail. -->
<!-- You may want to answer some of the following questions: -->
<!-- What kind of change does this PR introduce?** (Bug fix, feature,
docs update, ...) -->
<!-- What is the current behavior?** (You can also link to an open issue
here) -->
<!-- What is the new behavior (if this is a feature change)? -->
<!-- Does this PR introduce a breaking change?** (What changes might
users need to make in their application due to this PR?) -->

## Related Issue(s)
closes #18
<!-- This project accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- Please link to the issue(s) here -->

<!-- Closes # -->
<!-- Fixes # -->

## Checklist

<!-- Please check if the PR fulfills these requirements. -->

-   [x] My code follows the style guidelines of this project
-   [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
-   [x] My changes generate no new warnings
- [x] I have run `yarn format` and `yarn compile` without getting any
errors
- [x] I have added tests that prove my fix is effective or that my
feature works
-   [x] New and existing unit tests pass locally with my changes
  • Loading branch information
github-actions[bot] committed Jul 11, 2024
1 parent 06c8ee9 commit 0c10c76
Show file tree
Hide file tree
Showing 24 changed files with 0 additions and 2,214 deletions.
85 changes: 0 additions & 85 deletions excubiae/README.md

This file was deleted.

59 changes: 0 additions & 59 deletions excubiae/src/Excubia.sol

This file was deleted.

46 changes: 0 additions & 46 deletions excubiae/src/IExcubia.sol

This file was deleted.

80 changes: 0 additions & 80 deletions excubiae/src/extensions/EASExcubia.sol

This file was deleted.

57 changes: 0 additions & 57 deletions excubiae/src/extensions/ERC721Excubia.sol

This file was deleted.

37 changes: 0 additions & 37 deletions excubiae/src/extensions/FreeForAllExcubia.sol

This file was deleted.

Loading

0 comments on commit 0c10c76

Please sign in to comment.