chore: generate coverage report #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
force-pushed
the
ci/coverage
branch
7 times, most recently
from
f583f9c to
ece3edd
Compare
sripwoud
commented
Aug 8, 2024
| @@ -38,7 +38,7 @@ maybe_install_local() { | |||
|
|
|||
| install_dev_deps() { | |||
| log "Installing development dependencies..." | |||
| crates="convco dprint cargo-nextest" | |||
| crates="convco dprint cargo-llvm-cov cargo-nextest" | |||
There was a problem hiding this comment.
sripwoud
added
devops 🔧
sripwoud
added a commit
that referenced
this pull request
Aug 8, 2024
I had deliberately ommitted the checkout step in the coverage job in #46 because I thought it was sufficient for `coveralls` to only have a coverage report file (`lcov.info`) in order to be able to report the coverage. But it is not, it needs to read the src files too, otherwise it fails with a [`nothing to report` error](https://github.com/privacy-scaling-explorations/zk-kit.rust/actions/runs/10300402250/job/28509727109#step:3:60). So we need to checkout. The [coverage job execution on this test branch](https://github.com/privacy-scaling-explorations/zk-kit.rust/actions/runs/10301338228/job/28512666893?pr=48#step:4:62) demonstrated that the fix is effective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coveragemake task to generate a coverage report to STDOUTlcov.inforeport when running the tests in the CI and upload that to coverallsCloses #43