ci: checkout before reporting coverage to coveralls #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sripwoud
added
bug 🐛
sripwoud
force-pushed
the
ci/fix-coveralls
branch
2 times, most recently
from
682dd0d to
2189a86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had deliberately ommitted the checkout step in the coverage job in #46 because I thought it was sufficient for
coverallsto only have a coverage report file (lcov.info) in order to be able to report the coverage.But it is not, it needs to read the src files too, otherwise it fails with a
nothing to reporterror.So we need to checkout.
The coverage job execution on this test branch demonstrated that the fix is effective.