Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): download all artifacts as tarball #108

Merged
merged 8 commits into from
Jun 27, 2024
Merged

feat(web): download all artifacts as tarball #108

merged 8 commits into from
Jun 27, 2024

Conversation

sripwoud
Copy link
Member

@sripwoud sripwoud commented Jun 26, 2024 •
edited
Loading

Closes #107
Closes #110
image

Test plan

  1. pnpm --filter web dev
  2. Select project then version
  3. Download is disabled
  4. Tick all:
    • select input should be disabled
    • checkbox has a tooltip
    • Download button is enabled
  5. Click dowload: you get the expected tarball archive

@sripwoud sripwoud added the enhancement New feature or request label Jun 26, 2024
@sripwoud sripwoud self-assigned this Jun 26, 2024
@sripwoud sripwoud requested a review from cedoor June 26, 2024 10:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd21ff5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sripwoud sripwoud marked this pull request as draft June 26, 2024 10:48
@sripwoud sripwoud marked this pull request as ready for review June 26, 2024 10:57
cedoor
cedoor reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment •
edited by sripwoud
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error while downloading the latest version of Semaphore.

Link: https://registry.npmjs.org/@zk-kit/semaphore-artifacts/-/semaphore-artifacts-latest.tgz

@sripwoud
Copy link
Member Author

sripwoud commented Jun 26, 2024 •
edited
Loading

@cedoor that is not really related to that PR is it?
Let's discuss here #110

@sripwoud sripwoud requested a review from cedoor June 26, 2024 12:14
@sripwoud sripwoud mentioned this pull request Jun 26, 2024
Closed
@cedoor
Copy link
Member

cedoor commented Jun 26, 2024

@cedoor that is not really related to that PR is it? Let's discuss here #110

Kind of, yes let's discuss this there!

@sripwoud
Copy link
Member Author

In the end I am fixing #110 here too.
I went with the solution of filtering 'latest' out from the list and ordering the versions in descending semantic order.

@sripwoud sripwoud added the bug 🐛 Something isn't working label Jun 27, 2024
@cedoor
Copy link
Member

cedoor commented Jun 27, 2024

In the end I am fixing #110 here too. I went with the solution of filtering 'latest' out from the list and ordering the versions in descending semantic order.

Makes sense 👍🏽

cedoor
cedoor approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works fine! LGTM 👍🏽

@sripwoud sripwoud merged commit 563c0d2 into main Jun 27, 2024
1 check passed
@sripwoud sripwoud deleted the feat/web-dl-all branch June 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

Assignees

@sripwoud sripwoud

Labels
bug 🐛 Something isn't working enhancement New feature or request
Projects
SNARK Artifacts
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(web): handle latest version Add option to download all artifacts on the registry webapp
2 participants
@sripwoud @cedoor