Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): handle latest version #110

Closed
sripwoud opened this issue Jun 26, 2024 · 0 comments · Fixed by #108
Closed

fix(web): handle latest version #110

sripwoud opened this issue Jun 26, 2024 · 0 comments · Fixed by #108
Assignees
Labels
enhancement New feature or request

Comments

@sripwoud
Copy link
Member

sripwoud commented Jun 26, 2024

See #108 (review)

Right now we display a "latest" option in the select input.
However https://registry.npmjs.org does not provide a direct download url for the latest version.

Different way to solve it:

  1. Fetch the latest explicit version value
     curl -s https://registry.npmjs.org/@zk-kit/semaphore-artifacts | jq '.["dist-tags"]'
     {
       "latest": "4.0.0-beta.11"
     }
    
  2. Do some sorting off line client side with e.g semver.
    Maybe we should not show a 'latest' option at all and simply sort versions in descending order?
@github-project-automation github-project-automation bot moved this to 📋 Backlog in SNARK Artifacts Jun 26, 2024
@sripwoud sripwoud self-assigned this Jun 26, 2024
@cedoor cedoor added the enhancement New feature or request label Jun 26, 2024
@cedoor cedoor moved this from 📋 Backlog to 🗒 Tasks in SNARK Artifacts Jun 26, 2024
@github-project-automation github-project-automation bot moved this from 🗒 Tasks to ✔️ Done in SNARK Artifacts Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

2 participants