Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: several bugs due to rebase #179

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix: several bugs due to rebase #179

merged 1 commit into from
Jun 28, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Jun 25, 2024 •
edited
Loading

Description

  • fix missing return types
  • adding empty line between elements
  • re-order imports
  • re-order functions and components in a single file
  • remove redundant conditional check
  • fix all lint errors

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 2:40pm

@kittybest kittybest mentioned this pull request Jun 25, 2024
Closed
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 313804f to 4a1b17b Compare June 26, 2024 08:02
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 4a1b17b to 697faa4 Compare June 26, 2024 09:07
@kittybest kittybest marked this pull request as ready for review June 26, 2024 09:08
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 697faa4 to ecb5b00 Compare June 26, 2024 09:12
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from ecb5b00 to 53a273e Compare June 26, 2024 09:44
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 53a273e to 8866bfc Compare June 26, 2024 09:53
ctrlc03
ctrlc03 reviewed Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! just one comment

public/mockServiceWorker.js Show resolved Hide resolved
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 8866bfc to 886b766 Compare June 26, 2024 13:40
0xmad
0xmad requested changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, left some comments

src/components/Footer.tsx Outdated Show resolved Hide resolved
src/components/SortByDropdown.tsx Outdated Show resolved Hide resolved
src/components/ui/Dialog.tsx Outdated Show resolved Hide resolved
src/components/ui/Dialog.tsx Outdated Show resolved Hide resolved
src/components/ui/Dialog.tsx Show resolved Hide resolved
src/contexts/Maci.tsx Outdated Show resolved Hide resolved
src/features/ballot/components/SubmitBallotButton.tsx Outdated Show resolved Hide resolved
src/features/projects/components/Projects.tsx Outdated Show resolved Hide resolved
src/features/projects/components/ProjectsResults.tsx Outdated Show resolved Hide resolved
src/pages/ballot/index.tsx Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 886b766 to 2254e1b Compare June 26, 2024 14:00
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 2254e1b to 546eb73 Compare June 26, 2024 14:32
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 546eb73 to 1062fd0 Compare June 26, 2024 15:47
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 1062fd0 to 00c4e89 Compare June 26, 2024 16:02
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 00c4e89 to 5244441 Compare June 26, 2024 16:40
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 96ad1de to 44cf53e Compare June 27, 2024 00:31
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 44cf53e to e09e563 Compare June 27, 2024 12:24
0xmad
0xmad reviewed Jun 27, 2024
View reviewed changes
src/contexts/Maci.tsx Outdated Show resolved Hide resolved
src/contexts/Maci.tsx Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from e09e563 to 24681a3 Compare June 27, 2024 13:18
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 24681a3 to 8ec1403 Compare June 27, 2024 13:33
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 8ec1403 to f7a390b Compare June 27, 2024 13:50
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from f7a390b to abf2674 Compare June 27, 2024 13:57
@kittybest kittybest mentioned this pull request Jun 27, 2024
Closed
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from abf2674 to 4c63fa1 Compare June 28, 2024 09:24
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 4c63fa1 to 0edbbf0 Compare June 28, 2024 09:45
ctrlc03
ctrlc03 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

0xmad
0xmad reviewed Jun 28, 2024
View reviewed changes
src/contexts/Maci.tsx Outdated Show resolved Hide resolved
src/features/projects/components/VotingWidget.tsx Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 0edbbf0 to 086ea3e Compare June 28, 2024 14:33
0xmad
0xmad approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest kittybest force-pushed the fix/design-ui-after-rebase branch from 086ea3e to 398ea56 Compare June 28, 2024 14:37
@kittybest kittybest merged commit bc69ce7 into feat/design-ui Jun 28, 2024
8 checks passed
@kittybest kittybest deleted the fix/design-ui-after-rebase branch June 28, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad 0xmad approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03