-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add faq section #176
Conversation
…-hover-style feat: update hover style base on figma design
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left some comments
description={ | ||
<div className="flex flex-col gap-4"> | ||
<p> | ||
This round will be enabled by EasyRetroPGF Hypercerts EAS and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure Hypercerts is relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I forgot to change this part, just copy paste from the figma file. Would change this part.
/> | ||
<FAQItem | ||
title="Who are the requirements for participation?" | ||
description="To participate in this round as a project or as a voter, you must be a Mexican community member and have on-chain proofs, such as: POAPs, Unlock Protocol, NFTs or EAS." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure it should say Mexican community memeber? maybe we can keep it more general "To participate in this round as a project or as a voter, you will need to be approved by the round operators."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have a question: what kind of FAQ are we going to provide? since these contents are generated by the design team, and they have this randomly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably provide some general q/a around what rpgf is, what maci is + we can leave the ones you added but with a general answer so whoever forks just changes to what makes sense for their case
<h1 className="mb-8">FAQ</h1> | ||
<FAQItem | ||
title="what is the focus of this round?" | ||
description="This found is focused on supporting Mexican projects working on reducing the gender gap, collaborating with local communities, and ReFi." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it general. "This round is focused on supporting public goods projects".
I assume projects forking the projects will add their own faqs + changes these answers
/> | ||
<FAQItem | ||
title="Do you have any other questions?" | ||
description="Join our Telegram group to learn more!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
telegram group? maybe let's put a link to MACI's public channel on discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
@ctrlc03 so this is actually a template for those who wanna fork our repo and do their own FAQ, so actually these contents are just example text. However I agree it would be confusing. Maybe let's make it more reasonable to be example FAQ content? (but I have no idea what kind of content could be example) |
yea I think we could have one faq each around what maci and maci-rpgf are, then requirements, what is public goods funding and method of reaching out for more questions (discord public channel for now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kittybest thanks, left some comments
marginTop?: boolean; | ||
paddingX?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a good practice to pass single style props. Better to pass className
using clsx
6069ed9
to
529eb05
Compare
since this would be hard to rebase, would open another PR for this faq integration branch from current |
bc69ce7
to
1e2d2ee
Compare
close by #190 |
DefaultLayout
to allow customized marginBlocker
#179